You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "rdblue (via GitHub)" <gi...@apache.org> on 2023/09/02 23:16:03 UTC

[GitHub] [iceberg] rdblue commented on a diff in pull request #6399: API: Add strict metadata cleanup to SnapshotProducer

rdblue commented on code in PR #6399:
URL: https://github.com/apache/iceberg/pull/6399#discussion_r1314026358


##########
core/src/main/java/org/apache/iceberg/SnapshotProducer.java:
##########
@@ -396,7 +399,9 @@ public void commit() {
     } catch (CommitStateUnknownException commitStateUnknownException) {
       throw commitStateUnknownException;
     } catch (RuntimeException e) {
-      Exceptions.suppressAndThrow(e, this::cleanAll);
+      if (!strictCleanup || e instanceof CleanableFailure) {
+        Exceptions.suppressAndThrow(e, this::cleanAll);

Review Comment:
   Yes! Good catch. Amogh is fixing this in the updated PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org