You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/01/30 10:41:49 UTC
[GitHub] [commons-jcs] simon04 opened a new pull request #10: Tune logging:
assume that info is enabled
simon04 opened a new pull request #10: Tune logging: assume that info is enabled
URL: https://github.com/apache/commons-jcs/pull/10
This removes lots of clutter in the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-jcs] simon04 commented on issue #10: Tune logging: assume
that info is enabled
Posted by GitBox <gi...@apache.org>.
simon04 commented on issue #10: Tune logging: assume that info is enabled
URL: https://github.com/apache/commons-jcs/pull/10#issuecomment-594188370
I'm happy to revise my PR if there's a realistic change for its approval. What about my other, less disputable PRs #8 and #9?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-jcs] simon04 closed pull request #10: Tune logging: assume
that info is enabled
Posted by GitBox <gi...@apache.org>.
simon04 closed pull request #10: Tune logging: assume that info is enabled
URL: https://github.com/apache/commons-jcs/pull/10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-jcs] rdsprinkle commented on issue #10: Tune logging:
assume that info is enabled
Posted by GitBox <gi...@apache.org>.
rdsprinkle commented on issue #10: Tune logging: assume that info is enabled
URL: https://github.com/apache/commons-jcs/pull/10#issuecomment-586374021
Bypassing the tests for log.info enabled means that each item always performs a String concatenation to build the log message. You should pass the message in as separate arguments and then log will only perform the concatenation if it is enabled.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-jcs] rsprinkle commented on issue #10: Tune logging:
assume that info is enabled
Posted by GitBox <gi...@apache.org>.
rsprinkle commented on issue #10: Tune logging: assume that info is enabled
URL: https://github.com/apache/commons-jcs/pull/10#issuecomment-595199522
>
>
> I'm happy to revise my PR if there's a realistic change for its approval. What about my other, less disputable PRs #8 and #9?
I am just a user, so I don't have any input into the approval. But given the low overhead of a call to a disabled log statement and the reduction in clutter, I personally would be in favor, provided the cost of building the log message was eliminated when not used. Hence my earlier comment.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-jcs] simon04 commented on issue #10: Tune logging: assume
that info is enabled
Posted by GitBox <gi...@apache.org>.
simon04 commented on issue #10: Tune logging: assume that info is enabled
URL: https://github.com/apache/commons-jcs/pull/10#issuecomment-600140985
@tvand, you've convinced me …
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services