You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "Donny9 (via GitHub)" <gi...@apache.org> on 2024/09/08 10:23:15 UTC

[PR] include/sensors: import public definitions types and to uorb.h [nuttx]

Donny9 opened a new pull request, #13324:
URL: https://github.com/apache/nuttx/pull/13324

   
   
   ## Summary
   Import public definitions types and to uorb.h, this PR is related to https://github.com/apache/nuttx-apps/pull/2556
   ## Impact
   header path change for system/uorb/
   ## Testing
   Vela and local testing~
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] include/sensors: import public definitions types and to uorb.h [nuttx]

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #13324:
URL: https://github.com/apache/nuttx/pull/13324


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] include/sensors: import public definitions types and to uorb.h [nuttx]

Posted by "Donny9 (via GitHub)" <gi...@apache.org>.
Donny9 commented on PR #13324:
URL: https://github.com/apache/nuttx/pull/13324#issuecomment-2336994715

   > @Donny9 since the symbols still called SENSOR_ why don't you move it to include/nuttx/sensors/uorb.h ? I think it will make more sense
   
   @acassis 
   1. Sensors are just a part of uORB, and there are many virtual topics used within uORB as well. For the library apps/system/uorb/, the nuttx/uorb.h version is more preferable.
   2. We have ported uORB to Linux internally, and since there is no sensor directory under include/linux, in order to maintain consistency, we placed uorb.h under include/nuttx
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] include/sensors: import public definitions types and to uorb.h [nuttx]

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #13324:
URL: https://github.com/apache/nuttx/pull/13324#issuecomment-2336734277

   @Donny9 since the symbols still called SENSOR_ why don't you move it to include/nuttx/sensors/uorb.h ? I think it will make more sense


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org