You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Adam B <ad...@mesosphere.io> on 2015/06/02 10:10:47 UTC
Re: Review Request 33058: Updated test-frameworks to support
principal only credential.
> On May 13, 2015, 4:28 p.m., Bernd Mathiske wrote:
> > src/examples/java/TestFramework.java, line 251
> > <https://reviews.apache.org/r/33058/diff/2/?file=922676#file922676line251>
> >
> > line > 80 chars
There are many lines in the java files with line > 80 chars, or even > 100 chars.
I don't think our C++ style guide necessarily covers Java style. Dropping the issue.
- Adam
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33058/#review83683
-----------------------------------------------------------
On April 10, 2015, 12:25 a.m., Till Toenshoff wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33058/
> -----------------------------------------------------------
>
> (Updated April 10, 2015, 12:25 a.m.)
>
>
> Review request for mesos, Adam B and Alexander Rojas.
>
>
> Bugs: MESOS-2608
> https://issues.apache.org/jira/browse/MESOS-2608
>
>
> Repository: mesos-incubating
>
>
> Description
> -------
>
> see summary.
>
>
> Diffs
> -----
>
> src/examples/java/TestFramework.java 9e95369
> src/examples/python/test_framework.py a179df5
> src/examples/test_framework.cpp 9f4b53e
>
> Diff: https://reviews.apache.org/r/33058/diff/
>
>
> Testing
> -------
>
> make check + functional testing using custom authentication modules not relying on a shared secrets.
>
>
> Thanks,
>
> Till Toenshoff
>
>