You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@parquet.apache.org by Zoltan Ivanfi <zi...@cloudera.com> on 2018/05/15 14:31:12 UTC

Feature branch for column indexes

Hi,

We would like to create a feature branch for column indexes. Related
commits would need to be reviewed by the community just the same, but
would be merged to the feature branch instead of master. Once the
feature works end-to-end, we would merge it into master in a single
merge commit (also to be reviewed by the community).

Does anyone have any objections to or concerns about this approach?
(I'm happy to elaborate on the motivation if anyone is interested.)

Can anyone advise what we need to do in order to have the regular
infrastructure (like Travis builds) work on the feature branch?

Thanks,

Zoltan

Re: Feature branch for column indexes

Posted by Zoltan Ivanfi <zi...@cloudera.com>.
Hi Uwe,

Thanks, I just created the feature branch a few hours ago and Travis works
indeed.

The feature branch is in the apache repo as we would like the PR-s to be
public and open to any committers and contributors so that we won't have to
post the changes for review again when we would like to merge them.

Zoltan

On Thu, May 17, 2018 at 5:33 PM Uwe L. Korn <uw...@xhochy.com> wrote:

> Hello Zoltan,
>
> > Can anyone advise what we need to do in order to have the regular
> > infrastructure (like Travis builds) work on the feature branch?
>
> You probably should get this for free if you make that branch on the main
> parquet-mr repository. This will then limit the people that can merge to
> that branch to committers. Otherwise, you could do that on also in your
> private forks and activate Travis on them. Normally this also works fine (I
> usually do that in Arrow as the main Travis queue is much longer and only
> pushing to my private fork I can get quicker feedback).
>
> Uwe
>

Re: Feature branch for column indexes

Posted by "Uwe L. Korn" <uw...@xhochy.com>.
Hello Zoltan,

> Can anyone advise what we need to do in order to have the regular
> infrastructure (like Travis builds) work on the feature branch?

You probably should get this for free if you make that branch on the main parquet-mr repository. This will then limit the people that can merge to that branch to committers. Otherwise, you could do that on also in your private forks and activate Travis on them. Normally this also works fine (I usually do that in Arrow as the main Travis queue is much longer and only pushing to my private fork I can get quicker feedback).

Uwe