You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "felipecrv (via GitHub)" <gi...@apache.org> on 2024/03/17 01:49:08 UTC
[I] [C++] Rename `Function::is_impure()` to `is_pure()` [arrow]
felipecrv opened a new issue, #40607:
URL: https://github.com/apache/arrow/issues/40607
### Describe the enhancement requested
Remove the property negation from the function name so that reasoning about the boolean value is easier.
"is_impure = false" vs "is_pure = true"
"is_impure" vs "!is_pure"
### Component(s)
C++
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Rename `Function::is_impure()` to `is_pure()` [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on issue #40607:
URL: https://github.com/apache/arrow/issues/40607#issuecomment-2083548721
Thanks for catching my mistake @mapleFU! I didn't catch that the change was against unreleased code and I should have caught that before commenting here.
I put up a PR to remove it from the blog post: https://github.com/apache/arrow-site/pull/511.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Rename `Function::is_impure()` to `is_pure()` [arrow]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on issue #40607:
URL: https://github.com/apache/arrow/issues/40607#issuecomment-2005362310
Issue resolved by pull request 40608
https://github.com/apache/arrow/pull/40608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Rename `Function::is_impure()` to `is_pure()` [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on issue #40607:
URL: https://github.com/apache/arrow/issues/40607#issuecomment-2082824060
@amoeba This is not a breaking change since is_pure is also new added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Rename `Function::is_impure()` to `is_pure()` [arrow]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on issue #40607:
URL: https://github.com/apache/arrow/issues/40607#issuecomment-2083144163
It could be breaking for people programming against what is available on the `main` because I flipped the meaning of a boolean parameter. Perhaps it's one of those cases where it's better to safe than sorry.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Rename `Function::is_impure()` to `is_pure()` [arrow]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv commented on issue #40607:
URL: https://github.com/apache/arrow/issues/40607#issuecomment-2082910494
Exactly. I pushed the rename because it was a recent addition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Rename `Function::is_impure()` to `is_pure()` [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on issue #40607:
URL: https://github.com/apache/arrow/issues/40607#issuecomment-2083762147
https://github.com/apache/arrow-site/pull/511 has been merged so this is no longer marked as breaking in the release blog post.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Rename `Function::is_impure()` to `is_pure()` [arrow]
Posted by "amoeba (via GitHub)" <gi...@apache.org>.
amoeba commented on issue #40607:
URL: https://github.com/apache/arrow/issues/40607#issuecomment-2080244437
Hi @felipecrv, this looks like a breaking change to me. What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Rename `Function::is_impure()` to `is_pure()` [arrow]
Posted by "mapleFU (via GitHub)" <gi...@apache.org>.
mapleFU commented on issue #40607:
URL: https://github.com/apache/arrow/issues/40607#issuecomment-2082986367
I found this is marked as "breaking change" in release note, but it's not required, lol: https://arrow.apache.org/blog/2024/04/20/16.0.0-release/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [C++] Rename `Function::is_impure()` to `is_pure()` [arrow]
Posted by "felipecrv (via GitHub)" <gi...@apache.org>.
felipecrv closed issue #40607: [C++] Rename `Function::is_impure()` to `is_pure()`
URL: https://github.com/apache/arrow/issues/40607
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org