[jira] [Resolved] (ARROW-10397) [C++] Outdated and confusing comment on dictionary indices

["Micah Kornfield (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/ARROW-10397?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Micah Kornfield resolved ARROW-10397.
-------------------------------------
    Fix Version/s: 3.0.0
       Resolution: Fixed

Issue resolved by pull request 8535
[https://github.com/apache/arrow/pull/8535]

> [C++] Outdated and confusing comment on dictionary indices
> ----------------------------------------------------------
>
>                 Key: ARROW-10397
>                 URL: https://issues.apache.org/jira/browse/ARROW-10397
>             Project: Apache Arrow
>          Issue Type: Bug
>          Components: C++
>            Reporter: Carol Nichols
>            Assignee: Carol Nichols
>            Priority: Trivial
>              Labels: pull-request-available
>             Fix For: 3.0.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> While working on the Rust implementation, I got confused by [this comment|https://github.com/apache/arrow/blob/06d4f17247d8d4e1da730d3c7b380d522829f458/cpp/src/arrow/ipc/metadata_internal.cc#L430-L432] that said dictionary index types could be assumed to be signed integers. The Rust code allowed for unsigned integers, so I thought the Rust code had a bug. However, I read the C++ code more carefully, and unsigned integers are allowed as dictionary index types-- this was changed in [this commit|https://github.com/apache/arrow/commit/b1a7a73ff2284f391b13588f4d7f65aa30df81e3] but the comment wasn't updated.
> I have a pull request fixing the comment, just want to save someone a few minutes of confusion :)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)