[GitHub] [couchdb] jaydoane commented on a diff in pull request #4363: Fix replication _scheduler/docs total_rows

[GitBox <gi...@apache.org>]

jaydoane commented on code in PR #4363:
URL: https://github.com/apache/couchdb/pull/4363#discussion_r1065403901


##########
src/couch_replicator/src/couch_replicator_httpd_util.erl:
##########
@@ -158,7 +158,7 @@ docs_cb({meta, Meta}, #vacc{meta_sent = false, row_sent = false} = Acc) ->
     Parts =
         case couch_util:get_value(total, Meta) of
             undefined -> [];
-            Total -> [io_lib:format("\"total_rows\":~p", [adjust_total(Total)])]
+            Total -> [io_lib:format("\"total_rows\":~p", [Total])]

Review Comment:
   Yes, because it's not actually doing I/O here, but just [formatting the string](https://www.erlang.org/doc/man/io_lib.html#format-2). Are you thinking of `io:format/2` maybe?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@couchdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org