You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@polaris.apache.org by "MonkeyCanCode (via GitHub)" <gi...@apache.org> on 2025/12/16 04:23:51 UTC
[I] Enforce mypy for CLI [polaris]
MonkeyCanCode opened a new issue, #3280:
URL: https://github.com/apache/polaris/issues/3280
### Is your feature request related to a problem? Please describe.
Currently we have mypy enabled but only for integration_tests dir (https://github.com/apache/polaris/blob/main/client/python/.pre-commit-config.yaml#L39C17-L39C34). This seems to be odd to have mypy only for integration but not for the actual CLI code base. If we do want to enforce code quality for static type checking via mypy, I would think we should do it on the actual code base for CLI.
### Describe the solution you'd like
Enable mypy for actual CLI code base.
### Describe alternatives you've considered
_No response_
### Additional context
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Enforce mypy for CLI [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on issue #3280:
URL: https://github.com/apache/polaris/issues/3280#issuecomment-3659020341
> Makes sense to enable the static type checking. BTW, did you see errors caught while enabling it?
Yes. Because there are many missing type hint. If no concern, I can proceed with the needed changes later this week.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Enforce mypy for CLI [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain closed issue #3280: Enforce mypy for CLI
URL: https://github.com/apache/polaris/issues/3280
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Enforce mypy for CLI [polaris]
Posted by "MonkeyCanCode (via GitHub)" <gi...@apache.org>.
MonkeyCanCode commented on issue #3280:
URL: https://github.com/apache/polaris/issues/3280#issuecomment-3658726027
Let me know if this is something we would like to support then I will make the needed changes (the existed CLI code base is not 100% static type validated) cc @HonahX @eric-maynard @flyrain
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Enforce mypy for CLI [polaris]
Posted by "flyrain (via GitHub)" <gi...@apache.org>.
flyrain commented on issue #3280:
URL: https://github.com/apache/polaris/issues/3280#issuecomment-3658975178
Makes sense to enable the static type checking. BTW, did you see errors caught while enabling it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Enforce mypy for CLI [polaris]
Posted by "adam-christian-software (via GitHub)" <gi...@apache.org>.
adam-christian-software commented on issue #3280:
URL: https://github.com/apache/polaris/issues/3280#issuecomment-3660823073
This is fantastic! Thanks for filing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org