You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@doris.apache.org by "zclllyybb (via GitHub)" <gi...@apache.org> on 2026/01/07 04:03:53 UTC

[PR] [Fix](function) fix skip null value for some date functions [doris]

zclllyybb opened a new pull request, #59616:
URL: https://github.com/apache/doris/pull/59616

   ### What problem does this PR solve?
   
   Issue Number: close #xxx
   
   Related PR: #xxx
   
   Problem Summary:
   
   for some functions like `dayname`, `add_time`... they should skip null rows. otherwise may cause false alarm. like this:
   before:
   ```sql
   mysql> SELECT      add_time (         tbl_alias1.col_date_undef_signed_not_null,         '23:30:01'     ) col_alias6 FROM table_1_20_undef_partitions2_keys3_properties4_distributed_by5 AS tbl_alias1     RIGHT JOIN table_3_20_undef_partitions2_keys3_properties4_distributed_by5 AS tbl_alias2 ON tbl_alias1.col_int_undef_signed_not_null = tbl_alias2.col_int_undef_signed_not_null;
   ERROR 1105 (HY000): errCode = 2, detailMessage = [INVALID_ARGUMENT]Operation add_time of , 84601000000.000000 is invalid
   ```
   now:
   ```sql
   mysql> SELECT      add_time (         tbl_alias1.col_date_undef_signed_not_null,         '23:30:01'     ) col_alias6 FROM table_1_20_undef_partitions2_keys3_properties4_distributed_by5 AS tbl_alias1     RIGHT JOIN table_3_20_undef_partitions2_keys3_properties4_distributed_by5 AS tbl_alias2 ON tbl_alias1.col_int_undef_signed_not_null = tbl_alias2.col_int_undef_signed_not_null;
   +---------------------+
   | col_alias6          |
   +---------------------+
   | 2023-12-10 23:30:01 |
   | 2023-12-18 23:30:01 |
   ......
   ```
   
   ### Release note
   
   None
   
   ### Check List (For Author)
   
   - Test <!-- At least one of them must be included. -->
       - [x] Regression test
       - [ ] Unit Test
       - [ ] Manual test (add detailed scripts or steps below)
       - [ ] No need to test or manual test. Explain why:
           - [ ] This is a refactor/code format and no logic has been changed.
           - [ ] Previous test can cover this change.
           - [ ] No code files have been changed.
           - [ ] Other reason <!-- Add your reason?  -->
   
   - Behavior changed:
       - [x] No.
       - [ ] Yes. <!-- Explain the behavior change -->
   
   - Does this need documentation?
       - [x] No.
       - [ ] Yes. <!-- Add document PR link here. eg: https://github.com/apache/doris-website/pull/1214 -->
   
   ### Check List (For Reviewer who merge this PR)
   
   - [ ] Confirm the release note
   - [ ] Confirm test cases
   - [ ] Confirm document
   - [ ] Add branch pick label <!-- Add branch pick label that this PR should merge into -->
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org