You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Kenneth Knowles (JIRA)" <ji...@apache.org> on 2018/10/16 17:07:00 UTC

[jira] [Commented] (BEAM-5771) PreCommits should support a flag to not run GCP tests

    [ https://issues.apache.org/jira/browse/BEAM-5771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652080#comment-16652080 ] 

Kenneth Knowles commented on BEAM-5771:
---------------------------------------

I would prefer to avoid flags. Let's compose the precommit from separate tasks that do the isolated parts.

> PreCommits should support a flag to not run GCP tests
> -----------------------------------------------------
>
>                 Key: BEAM-5771
>                 URL: https://issues.apache.org/jira/browse/BEAM-5771
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>    Affects Versions: 2.8.0
>            Reporter: Alan Myrvold
>            Assignee: Alan Myrvold
>            Priority: Major
>
> From [~swegner]
> There was some discussion recently about ensuring anyone can easily run and reproduce precommit test results locally. The precommits run Dataflow jobs, which will fail if you don't have access to an Google Cloud project. One idea would be to add a flag to disable Google Cloud tests, i.e. ./gradlew :javaPreCommit -PdisableGcpTests
> @sweg



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)