You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Martin Hoeller <ma...@xss.co.at> on 2012/11/19 20:55:35 UTC
[PATCH] update sample-maven-archetype
Hi!
I update the new sample-maven-archetype (see SHINDIG-1482) to use the
common container instead of the obsolete simple container, as
suggested by Ryan.
The archetype is not perfect now and could need some more documentation
in the JavaScript file, but at least it now uses the recent common
container. And I think it's a good starting point for integrating
shindig in your own webapp.
Please have a look at the patch before committing, as I'm still a
shindig beginner and it's very likely that I made some mistakes.
regards,
- martin
Re: [PATCH] update sample-maven-archetype
Posted by Martin Hoeller <ma...@xss.co.at>.
Done.
There is a new JIRA ticket: https://issues.apache.org/jira/browse/SHINDIG-1882
And a review request: https://reviews.apache.org/r/8160/
Hope I got it right. It's the first time I use Review Board.
hth,
- martin
On 20 Nov 2012, Franklin, Matthew B. wrote:
> Hi Martin,
>
> Please attach the patch to the JIRA ticket and open a review request at
> http://reviews.apache.org for the Shindig group.
>
> -Matt
>
> On 11/19/12 2:55 PM, "Martin Hoeller" <ma...@xss.co.at> wrote:
>
> >Hi!
> >
> >I update the new sample-maven-archetype (see SHINDIG-1482) to use the
> >common container instead of the obsolete simple container, as
> >suggested by Ryan.
> >
> >The archetype is not perfect now and could need some more documentation
> >in the JavaScript file, but at least it now uses the recent common
> >container. And I think it's a good starting point for integrating
> >shindig in your own webapp.
> >
> >Please have a look at the patch before committing, as I'm still a
> >shindig beginner and it's very likely that I made some mistakes.
> >
> >regards,
> >- martin
Re: [PATCH] update sample-maven-archetype
Posted by "Franklin, Matthew B." <mf...@mitre.org>.
Hi Martin,
Please attach the patch to the JIRA ticket and open a review request at
http://reviews.apache.org for the Shindig group.
-Matt
On 11/19/12 2:55 PM, "Martin Hoeller" <ma...@xss.co.at> wrote:
>Hi!
>
>I update the new sample-maven-archetype (see SHINDIG-1482) to use the
>common container instead of the obsolete simple container, as
>suggested by Ryan.
>
>The archetype is not perfect now and could need some more documentation
>in the JavaScript file, but at least it now uses the recent common
>container. And I think it's a good starting point for integrating
>shindig in your own webapp.
>
>Please have a look at the patch before committing, as I'm still a
>shindig beginner and it's very likely that I made some mistakes.
>
>regards,
>- martin