You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "jim0987795064 (via GitHub)" <gi...@apache.org> on 2026/09/26 02:48:18 UTC
[PR] KAFKA-20812: Move parts of KRaftClusterTest to KafkaClusterTestKitTest [kafka]
jim0987795064 opened a new pull request, #23589:
URL: https://github.com/apache/kafka/pull/23589
This PR moves some tests from KRaftClusterTest to KafkaClusterTestKitTest.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20812: Move parts of KRaftClusterTest to KafkaClusterTestKitTest [kafka]
Posted by "jim0987795064 (via GitHub)" <gi...@apache.org>.
jim0987795064 commented on code in PR #23589:
URL: https://github.com/apache/kafka/pull/23589#discussion_r4113388335
##########
test-common/test-common-runtime/src/test/java/org/apache/kafka/common/test/KafkaClusterTestKitTest.java:
##########
@@ -176,4 +198,148 @@ public void testExposedFaultHandlers() {
fail("Failed to initialize cluster", e);
}
}
+
+ @Test
+ @Tag("integration")
Review Comment:
Thanks for this suggestion.
I've updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20812: Move parts of KRaftClusterTest to KafkaClusterTestKitTest [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 commented on code in PR #23589:
URL: https://github.com/apache/kafka/pull/23589#discussion_r4112374170
##########
test-common/test-common-runtime/src/test/java/org/apache/kafka/common/test/KafkaClusterTestKitTest.java:
##########
@@ -176,4 +198,148 @@ public void testExposedFaultHandlers() {
fail("Failed to initialize cluster", e);
}
}
+
+ @Test
+ @Tag("integration")
Review Comment:
This should be on the class
##########
test-common/test-common-runtime/src/test/java/org/apache/kafka/common/test/KafkaClusterTestKitTest.java:
##########
@@ -176,4 +198,148 @@ public void testExposedFaultHandlers() {
fail("Failed to initialize cluster", e);
}
}
+
+ @Test
+ @Tag("integration")
+ @Timeout(120)
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] KAFKA-20812: Move parts of KRaftClusterTest to KafkaClusterTestKitTest [kafka]
Posted by "chia7712 (via GitHub)" <gi...@apache.org>.
chia7712 merged PR #23589:
URL: https://github.com/apache/kafka/pull/23589
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org