[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1048: feat(thirdparty): use official rocksdb

[GitBox <gi...@apache.org>]

acelyc111 commented on code in PR #1048:
URL: https://github.com/apache/incubator-pegasus/pull/1048#discussion_r919097840


##########
rdsn/thirdparty/CMakeLists.txt:
##########
@@ -378,9 +378,9 @@ ExternalProject_Add(jemalloc
 option(ROCKSDB_PORTABLE "build a portable binary" OFF)
 
 ExternalProject_Add(rocksdb
-        URL ${OSS_URL_PREFIX}/pegasus-rocksdb-ef29819c7a1ea9334ae170f506b653757f517a52.zip
-        https://github.com/XiaoMi/pegasus-rocksdb/archive/ef29819c7a1ea9334ae170f506b653757f517a52.zip
-        URL_MD5 2a6488cd87c37e0c2e42a5ca74bebc87
+        https://github.com/facebook/rocksdb/archive/refs/tags/v6.6.4.tar.gz

Review Comment:
   ```suggestion
           URL https://github.com/facebook/rocksdb/archive/refs/tags/v6.6.4.tar.gz
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org