[jira] [Comment Edited] (KYLIN-3049) Filter the invalid zero value of "Auto Merge Thresholds" parameter when you create or upate a cube.

["Zhixiong Chen (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KYLIN-3049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16264296#comment-16264296 ] 

Zhixiong Chen edited comment on KYLIN-3049 at 11/23/17 1:06 PM:
----------------------------------------------------------------

Hi,[~peng.jianhua]
This patch will block model save.
I have revert this patch.
You shouldn't write the business code in utils.js 
utils.js is as a tool 
You could write in cubeEdit.js.


was (Author: zhixiong chen):
This patch will block model save.
I have revert this patch.
You shouldn't write the business code in utils.js 
utils.js is as a tool 
You could write in cubeEdit.js.

> Filter the invalid zero value of "Auto Merge Thresholds" parameter when you create or upate a cube.
> ---------------------------------------------------------------------------------------------------
>
>                 Key: KYLIN-3049
>                 URL: https://issues.apache.org/jira/browse/KYLIN-3049
>             Project: Kylin
>          Issue Type: Bug
>          Components: Web 
>            Reporter: peng.jianhua
>            Assignee: peng.jianhua
>              Labels: patch, scope
>             Fix For: v2.3.0
>
>         Attachments: 0001-KYLIN-3049-Filter-the-invalid-zero-value-of-Auto-Mer.patch, add_or_update_cube.png, show_cube.png
>
>
> 1. Open the Model page;
> 2. Create a new cube, click the "New Thresholds" button in the "Refresh Setting" tab, and don't input any value( refer to [^add_or_update_cube.png]), then complete the follow steps, at last save it;
> 3. Choose the cube you just created, go to the "Refresh Setting" tab, you will find the zero hours in "Auto Merge Thresholds" list, which is invalid but saved in the server( refer to [^show_cube.png]);
> 4. Similarly, update a existent cube, do the same steps, you will also find the invalid zero value saved in the server.
> As we know, the zero value of "Auto Merge Thresholds" parameter is invalid, so we should filter it before sending it to server.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)