[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #2494: Update new-license.md

[GitBox <gi...@apache.org>]

ashulin commented on code in PR #2494:
URL: https://github.com/apache/incubator-seatunnel/pull/2494#discussion_r951110231


##########
docs/en/contribution/new-license.md:
##########
@@ -31,6 +31,23 @@ We need to follow the following steps when we need to add new jars or external r
 * Append relevant NOTICE files under 'seatunnel-dist/release-docs/NOTICE' directory and make sure they are no different to the original repository
 * Add relevant source code protocols under 'seatunnel-dist/release-docs/licenses' directory and the file name should be named as license+filename.txt. Eg: license-zk.txt
 
+* check dependency license fail
+```
+--- /dev/fd/63 2020-12-03 03:08:57.191579482 +0000
++++ /dev/fd/62 2020-12-03 03:08:57.191579482 +0000
+@@ -1,0 +2 @@
++HikariCP-java6-2.3.13.jar
+@@ -16,0 +18 @@
++c3p0-0.9.5.2.jar
+@@ -149,0 +152 @@
++mchange-commons-java-0.2.11.jar

Review Comment:
   Do we need to add jar reduction cases?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org