You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Aileen Toleikis <ai...@hpe.com> on 2021/11/09 13:02:12 UTC
Re: Review Request 73286: Initial commit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73286/
-----------------------------------------------------------
(Updated Nov. 9, 2021, 1:02 nachm.)
Review request for atlas.
Changes
-------
SchemaRegistryConnector line 50: inserted try/catch for test
Repository: atlas
Description
-------
The Kafka Community is using Schema Registry more and more heavily but as Atlas is currently unaware of this, this extension helps Atlas make use of the Schemas.
We have tested this extension and we have production environments where Atlas will not be allowed without schema registry access. We have received feedback that this extension would be sufficient to allow production use.
Changes:
initial commit
added schema creation in Atlas
added Schema creation, Schema linkage and started to work on versions
avro_field creation is working. However, there is no connection to schemas yet
smaller refactorings and improved logging
added field reference in schemas
deleted second README and added gitignore
Smaller changes after rebasing on new version
moved HTTP REST calls to a separate class (SchemaRegistryConnector.java)
added testCreateSchema() as test case
added testCreateField() and testUpdateField() as test case
added testGetSchemas() and testGetSchemaVersions() as test case
added testUpdateSchema() as test case
removed unnecessary comments
Diffs (updated)
-----
addons/kafka-bridge/pom.xml 2ac19fd20e0c0322b0d104641ddd5a2ef89bf9d0
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java f9548244364a8f79f346411739348d0d53298c99
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java PRE-CREATION
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/model/KafkaDataTypes.java 0f81b4c37a1d8f84c587a914eb460b290ae36987
addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java f86ceb58fd250d80f3ae3c71085c8c0adbc9116b
pom.xml 47768e9fa7d8abcfc81cd148917400ac478a333a
Diff: https://reviews.apache.org/r/73286/diff/5/
Changes: https://reviews.apache.org/r/73286/diff/4-5/
Testing
-------
Thanks,
Aileen Toleikis
Re: Review Request 73286: Initial commit
Posted by Sidharth Mishra <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73286/#review223720
-----------------------------------------------------------
Ship it!
Ship It!
- Sidharth Mishra
On Nov. 9, 2021, 1:02 p.m., Aileen Toleikis wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73286/
> -----------------------------------------------------------
>
> (Updated Nov. 9, 2021, 1:02 p.m.)
>
>
> Review request for atlas.
>
>
> Repository: atlas
>
>
> Description
> -------
>
> The Kafka Community is using Schema Registry more and more heavily but as Atlas is currently unaware of this, this extension helps Atlas make use of the Schemas.
>
> We have tested this extension and we have production environments where Atlas will not be allowed without schema registry access. We have received feedback that this extension would be sufficient to allow production use.
>
> Changes:
>
> initial commit
>
>
> added schema creation in Atlas
>
>
> added Schema creation, Schema linkage and started to work on versions
>
>
> avro_field creation is working. However, there is no connection to schemas yet
>
>
> smaller refactorings and improved logging
>
>
> added field reference in schemas
>
>
> deleted second README and added gitignore
>
>
> Smaller changes after rebasing on new version
>
>
> moved HTTP REST calls to a separate class (SchemaRegistryConnector.java)
>
>
> added testCreateSchema() as test case
>
>
> added testCreateField() and testUpdateField() as test case
>
>
> added testGetSchemas() and testGetSchemaVersions() as test case
>
>
> added testUpdateSchema() as test case
>
>
> removed unnecessary comments
>
>
> Diffs
> -----
>
> addons/kafka-bridge/pom.xml 2ac19fd20e0c0322b0d104641ddd5a2ef89bf9d0
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java f9548244364a8f79f346411739348d0d53298c99
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java PRE-CREATION
> addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/model/KafkaDataTypes.java 0f81b4c37a1d8f84c587a914eb460b290ae36987
> addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java f86ceb58fd250d80f3ae3c71085c8c0adbc9116b
> pom.xml 47768e9fa7d8abcfc81cd148917400ac478a333a
>
>
> Diff: https://reviews.apache.org/r/73286/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aileen Toleikis
>
>
Re: Review Request 73286: Initial commit
Posted by Aileen Toleikis <ai...@hpe.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73286/
-----------------------------------------------------------
(Updated Nov. 15, 2021, 4:59 nachm.)
Review request for atlas.
Changes
-------
From: aileen.toleikis@hpe.com
Date: 15.Nov.2021
Subject: Make Kafka Interface aware of Kafka Schema Registry
Recent successful CI build - https://ci-builds.apache.org/job/Atlas/job/PreCommit-ATLAS-Build-Test/956/
Repository: atlas
Description
-------
The Kafka Community is using Schema Registry more and more heavily but as Atlas is currently unaware of this, this extension helps Atlas make use of the Schemas.
We have tested this extension and we have production environments where Atlas will not be allowed without schema registry access. We have received feedback that this extension would be sufficient to allow production use.
Changes:
initial commit
added schema creation in Atlas
added Schema creation, Schema linkage and started to work on versions
avro_field creation is working. However, there is no connection to schemas yet
smaller refactorings and improved logging
added field reference in schemas
deleted second README and added gitignore
Smaller changes after rebasing on new version
moved HTTP REST calls to a separate class (SchemaRegistryConnector.java)
added testCreateSchema() as test case
added testCreateField() and testUpdateField() as test case
added testGetSchemas() and testGetSchemaVersions() as test case
added testUpdateSchema() as test case
removed unnecessary comments
Diffs (updated)
-----
addons/kafka-bridge/pom.xml 2ac19fd20e0c0322b0d104641ddd5a2ef89bf9d0
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/KafkaBridge.java f9548244364a8f79f346411739348d0d53298c99
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/bridge/SchemaRegistryConnector.java PRE-CREATION
addons/kafka-bridge/src/main/java/org/apache/atlas/kafka/model/KafkaDataTypes.java 0f81b4c37a1d8f84c587a914eb460b290ae36987
addons/kafka-bridge/src/test/java/org/apache/atlas/kafka/bridge/KafkaBridgeTest.java f86ceb58fd250d80f3ae3c71085c8c0adbc9116b
pom.xml 47768e9fa7d8abcfc81cd148917400ac478a333a
Diff: https://reviews.apache.org/r/73286/diff/6/
Changes: https://reviews.apache.org/r/73286/diff/5-6/
Testing
-------
Thanks,
Aileen Toleikis