You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by maropu <gi...@git.apache.org> on 2018/08/21 10:52:49 UTC

[GitHub] spark pull request #17400: [SPARK-19981][SQL] Respect aliases in output part...

Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17400#discussion_r211561522
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/exchange/EnsureRequirements.scala ---
    @@ -321,6 +321,58 @@ case class EnsureRequirements(conf: SQLConf) extends Rule[SparkPlan] {
         }
       }
     
    +  private def updatePartitioningByAliases(exprs: Seq[NamedExpression], partioning: Partitioning)
    +    : Partitioning = {
    +    val aliasSeq = exprs.flatMap(_.collectFirst {
    --- End diff --
    
    This pr only focuses on aliases, so the point you described above is out-of-scope in this pr. IMO more complicated cases should be fixed in follow-ups.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org