You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Madhan Neethiraj <ma...@apache.org> on 2022/12/12 22:20:29 UTC
Review Request 74252: RANGER-4014: fix for handling resource names having macros in masking/row-filtering policies
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74252/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
Bugs: RANGER-4014
https://issues.apache.org/jira/browse/RANGER-4014
Repository: ranger
Description
-------
updated getResourceACLs() to use wildcard enabld resource-def
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java b4b2780a9
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java 159617b39
agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java 78e2f1884
agents-common/src/test/resources/policyengine/test_aclprovider_mask_filter.json 6ff4886ce
Diff: https://reviews.apache.org/r/74252/diff/1/
Testing
-------
- added unit tests to cover masking/row-filter policies with resources having macros
- verified that exist tests pass successfully
Thanks,
Madhan Neethiraj
Re: Review Request 74252: RANGER-4014: fix for handling resource names having macros in masking/row-filtering policies
Posted by Ankita Sinha <an...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74252/#review225001
-----------------------------------------------------------
Ship it!
Ship It!
- Ankita Sinha
On Dec. 12, 2022, 10:20 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74252/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2022, 10:20 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4014
> https://issues.apache.org/jira/browse/RANGER-4014
>
>
> Repository: ranger
>
>
> Description
> -------
>
> updated getResourceACLs() to use wildcard enabld resource-def
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java b4b2780a9
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java 159617b39
> agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java 78e2f1884
> agents-common/src/test/resources/policyengine/test_aclprovider_mask_filter.json 6ff4886ce
>
>
> Diff: https://reviews.apache.org/r/74252/diff/2/
>
>
> Testing
> -------
>
> - added unit tests to cover masking/row-filter policies with resources having macros
> - verified that exist tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>
Re: Review Request 74252: RANGER-4014: fix for handling resource names having macros in masking/row-filtering policies
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74252/#review225004
-----------------------------------------------------------
Ship it!
Ship It!
- Abhay Kulkarni
On Dec. 12, 2022, 10:20 p.m., Madhan Neethiraj wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74252/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2022, 10:20 p.m.)
>
>
> Review request for ranger, Ankita Sinha, Kishor Gollapalliwar, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Siddhesh Phatak, Sailaja Polavarapu, Subhrat Chaudhary, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-4014
> https://issues.apache.org/jira/browse/RANGER-4014
>
>
> Repository: ranger
>
>
> Description
> -------
>
> updated getResourceACLs() to use wildcard enabld resource-def
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java b4b2780a9
> agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerAbstractPolicyEvaluator.java 159617b39
> agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java 78e2f1884
> agents-common/src/test/resources/policyengine/test_aclprovider_mask_filter.json 6ff4886ce
>
>
> Diff: https://reviews.apache.org/r/74252/diff/2/
>
>
> Testing
> -------
>
> - added unit tests to cover masking/row-filter policies with resources having macros
> - verified that exist tests pass successfully
>
>
> Thanks,
>
> Madhan Neethiraj
>
>