You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/03/11 20:29:52 UTC
[GitHub] [maven-shared-utils] elharo opened a new pull request #21: system
independent file separator
elharo opened a new pull request #21: system independent file separator
URL: https://github.com/apache/maven-shared-utils/pull/21
@rfscholte see if we can make DirectoryScannerTest pass on Windows
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-shared-utils] elharo commented on issue #21: [MSHARED-862]
system independent file separator
Posted by GitBox <gi...@apache.org>.
elharo commented on issue #21: [MSHARED-862] system independent file separator
URL: https://github.com/apache/maven-shared-utils/pull/21#issuecomment-598344737
Slack + email. I don't have a major preference here one way or the other, but I am getting contradictory requests about merging from different committers and PMC members, so let's figure out what everyone is most comfortable with, document that decision, and configure the repos to make it the default or only option.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-shared-utils] michael-o commented on issue #21:
[MSHARED-862] system independent file separator
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #21: [MSHARED-862] system independent file separator
URL: https://github.com/apache/maven-shared-utils/pull/21#issuecomment-598240634
Ouch, you just have provided 6 junk commits on master. Please avoid that by squashing first. No merge commit since they don't add any benefit for us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-shared-utils] michael-o commented on issue #21:
[MSHARED-862] system independent file separator
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #21: [MSHARED-862] system independent file separator
URL: https://github.com/apache/maven-shared-utils/pull/21#issuecomment-598274676
Where did he request this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-shared-utils] elharo commented on issue #21: [MSHARED-862]
system independent file separator
Posted by GitBox <gi...@apache.org>.
elharo commented on issue #21: [MSHARED-862] system independent file separator
URL: https://github.com/apache/maven-shared-utils/pull/21#issuecomment-598226459
Build is blue (green) so I'm going to merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-shared-utils] elharo merged pull request #21: [MSHARED-862]
system independent file separator
Posted by GitBox <gi...@apache.org>.
elharo merged pull request #21: [MSHARED-862] system independent file separator
URL: https://github.com/apache/maven-shared-utils/pull/21
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-shared-utils] michael-o commented on issue #21:
[MSHARED-862] system independent file separator
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #21: [MSHARED-862] system independent file separator
URL: https://github.com/apache/maven-shared-utils/pull/21#issuecomment-598194952
>
>
> Interesting. I've never seen that one. Do you also see that one in master?
Yes, same on master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-shared-utils] michael-o commented on issue #21:
[MSHARED-862] system independent file separator
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #21: [MSHARED-862] system independent file separator
URL: https://github.com/apache/maven-shared-utils/pull/21#issuecomment-598138705
Let me run this too...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-shared-utils] elharo commented on issue #21: [MSHARED-862]
system independent file separator
Posted by GitBox <gi...@apache.org>.
elharo commented on issue #21: [MSHARED-862] system independent file separator
URL: https://github.com/apache/maven-shared-utils/pull/21#issuecomment-598255545
Squash commits have a different negative side effect that Robert has asked me to avoid. You should probably bring this up on the dev mailing list, so the community can decide what they want. When a decision is made, the repos can be configured to make the preferred way the only way.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-shared-utils] elharo commented on issue #21: [MSHARED-862]
system independent file separator
Posted by GitBox <gi...@apache.org>.
elharo commented on issue #21: [MSHARED-862] system independent file separator
URL: https://github.com/apache/maven-shared-utils/pull/21#issuecomment-598167061
Interesting. I've never seen that one. Do you also see that one in master?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services