[jira] [Work logged] (AVRO-3477) Fix logical types in C# if the base type is fixed

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/AVRO-3477?focusedWorklogId=751048&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-751048 ]

ASF GitHub Bot logged work on AVRO-3477:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 31/Mar/22 16:07
            Start Date: 31/Mar/22 16:07
    Worklog Time Spent: 10m 
      Work Description: zcsizmadia opened a new pull request #1629:
URL: https://github.com/apache/avro/pull/1629


   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [Avro Jira](https://issues.apache.org/jira/browse/AVRO-3477
     - https://issues.apache.org/jira/browse/AVRO-3477
     - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](https://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain Javadoc that explain what it does
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 751048)
    Remaining Estimate: 23h 50m  (was: 24h)
            Time Spent: 10m

> Fix logical types in C# if the base type is fixed
> -------------------------------------------------
>
>                 Key: AVRO-3477
>                 URL: https://issues.apache.org/jira/browse/AVRO-3477
>             Project: Apache Avro
>          Issue Type: Improvement
>          Components: csharp
>            Reporter: Zoltan Csizmadia
>            Priority: Critical
>   Original Estimate: 24h
>          Time Spent: 10m
>  Remaining Estimate: 23h 50m
>
> [~davidjsimonsTTD] mentioned this in https://issues.apache.org/jira/browse/AVRO-2359:
> I've been working with the initial MR for Logical Types and notice that as written the code doesn't support the following form of fixed decimal
>  
> {code:java}
> {
>   "name": "decimal_9", 
>   "type": "fixed", 
>   "size": 4,
>   "logicalType": "decimal", 
>   "precision": 9, 
>   "scale": 2"
> }
> {code}
>  
> The exception is currently:
> Avro.Test.LogicalTypeTests.TestFixedDecimal("-000000000000000001.01")
> Avro.SchemaParseException : Undefined name: fixed at 'type'
> at Avro.Schema.ParseJson(JToken jtok, SchemaNames names, String encspace) in C:\src\GitHub\avro\lang\csharp\src\apache\main\Schema\Schema.cs:line 174
> at Avro.LogicalSchema.NewInstance(JToken jtok, PropertyMap props, SchemaNames names, String encspace) in C:\src\GitHub\avro\lang\csharp\src\apache\main\Schema\LogicalSchema.cs:line 50
> at Avro.Schema.ParseJson(JToken jtok, SchemaNames names, String encspace) in C:\src\GitHub\avro\lang\csharp\src\apache\main\Schema\Schema.cs:line 196
> at Avro.Schema.Parse(String json, SchemaNames names, String encspace) in C:\src\GitHub\avro\lang\csharp\src\apache\main\Schema\Schema.cs:line 253
> at Avro.Schema.Parse(String json) in C:\src\GitHub\avro\lang\csharp\src\apache\main\Schema\Schema.cs:line 219
> at Avro.Test.LogicalTypeTests.TestFixedDecimal(String s) in C:\src\GitHub\avro\lang\csharp\src\apache\test\Util\LogicalTypeTests.cs:line 55.
>  
>  
> The usage of the above scenario is very powerfull if implementations, where you have hundreds of uses of decimal values where you want them to all, support the same specification.   I'm still looking at the code to understand what the best answer would be but it would need to be some form of named logical scheme. 



--
This message was sent by Atlassian Jira
(v8.20.1#820001)