You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mrunit.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2014/05/06 23:58:38 UTC
[jira] [Commented] (MRUNIT-198) Serialization is missing in
MockMultipleOutputs
[ https://issues.apache.org/jira/browse/MRUNIT-198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13991207#comment-13991207 ]
Hudson commented on MRUNIT-198:
-------------------------------
FAILURE: Integrated in mrunit-trunk #1119 (See [https://builds.apache.org/job/mrunit-trunk/1119/])
MRUNIT-198 - Serialization is missing in MockMultipleOutputs (Lars Grote via Brock) (brock: rev a18979ec6907a9d8fedc1fb4e6d3148433effd61)
* src/main/java/org/apache/hadoop/mrunit/TestDriver.java
* src/test/java/org/apache/hadoop/mrunit/mapreduce/TestMultipleOutput.java
* src/main/java/org/apache/hadoop/mrunit/internal/output/MockMultipleOutputs.java
> Serialization is missing in MockMultipleOutputs
> -----------------------------------------------
>
> Key: MRUNIT-198
> URL: https://issues.apache.org/jira/browse/MRUNIT-198
> Project: MRUnit
> Issue Type: Bug
> Affects Versions: 1.1.0
> Reporter: Lars Grote
> Assignee: Lars Grote
> Fix For: 1.1.0
>
> Attachments: MRUNIT-198-1.patch, MRUNIT-198.patch
>
>
> Hi,
> with issue MRUNIT-13 MockMultipleOutputs was introduced. Which is great! Unfortunately the inner class MockRecordWriter doesn't serialize the Object and therefore isn't storing a copy of the Object but the Object itself. I would suggest to use org.apache.hadoop.mrunit.internal.output.MockOutputCollector instead of the inner class. This Collector does store a copy of the Object and I see no point in having more or less the same Collector/Writer twice.
> Another thing that bugs me, is that MockMultipleOutputs requires you to use Comparable Objects in your MR Jobs, and I don't see for what reason this restriction is imposed on me.
> I'll provide a patch for this soon and would be glad if someone can comment on it.
> Cheers, Lars
--
This message was sent by Atlassian JIRA
(v6.2#6252)