You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/10/16 23:49:11 UTC

[GitHub] [incubator-tvm] rkimball commented on a change in pull request #6656: [Rust][Diagnostics] Add initial boilerplate for Rust diagnostic interface.

rkimball commented on a change in pull request #6656:
URL: https://github.com/apache/incubator-tvm/pull/6656#discussion_r506764888



##########
File path: cmake/modules/RustExt.cmake
##########
@@ -0,0 +1,26 @@
+if(USE_RUST_EXT AND NOT USE_RUST_EXT EQUAL OFF)

Review comment:
       We really need to stop overloading cmake bool and string. cmake is a simple thing and is easily confused. In the meantime us this instead. OFF is only one of the many valid values for cmake bool false.
   ```suggestion
   if(USE_RUST_EXT AND NOT ${USE_RUST_EXT} MATCHES ${IS_FALSE_PATTERN})
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org