[GitHub] [incubator-hudi] vinothchandar commented on a change in pull request #666: Add support for dynamic bloom filter to increase efficiency of bloom filter for static sizing

[GitBox <gi...@apache.org>]

vinothchandar commented on a change in pull request #666: Add support for dynamic bloom filter to increase efficiency of bloom filter for static sizing
URL: https://github.com/apache/incubator-hudi/pull/666#discussion_r281250851
 
 

 ##########
 File path: hoodie-client/src/main/java/com/uber/hoodie/config/HoodieIndexConfig.java
 ##########
 @@ -50,6 +50,9 @@
   public static final String BLOOM_INDEX_INPUT_STORAGE_LEVEL =
       "hoodie.bloom.index.input.storage" + ".level";
   public static final String DEFAULT_BLOOM_INDEX_INPUT_STORAGE_LEVEL = "MEMORY_AND_DISK_SER";
+  public static final String BLOOM_INDEX_ENABLE_DYNAMIC_PROP =
 
 Review comment:
   rename to "hoodie.bloom.index.dynamic.bloomfilter" or "hoodie.bloom.index.auto.tune.bloomfilter" ? to make it clearer it's about the bloom filter and not the index checking.. 
   
   Also this should probably belong in storage config? since its about how we write the parquet file right

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services