[GitHub] spark pull request: [SPARK-4969][STREAMING][PYTHON] Add binaryReco...

[JoshRosen <gi...@git.apache.org>]

Github user JoshRosen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3803#discussion_r22287877
  
    --- Diff: streaming/src/test/scala/org/apache/spark/streaming/InputStreamsSuite.scala ---
    @@ -233,6 +236,47 @@ class InputStreamsSuite extends TestSuiteBase with BeforeAndAfter {
         }
       }
     
    +  def testBinaryRecordsStream() {
    +    var ssc: StreamingContext = null
    +    val testDir: File = null
    +    try {
    +      val testDir = Utils.createTempDir()
    +
    +      Thread.sleep(1000)
    +      // Set up the streaming context and input streams
    +      val newConf = conf.clone.set(
    +        "spark.streaming.clock", "org.apache.spark.streaming.util.SystemClock")
    --- End diff --
    
    It looks like this is based on the FileInputStream test, which is known to be flaky.  I have a PR open which rewrites that test to not depend on SystemClock / Thread.sleep(): #3801.  Therefore, if we want to have this style of test, then this PR should block until my PR is merged so that it can use the new test utilities that I added.
    
    Here's the relevant change from my PR: https://github.com/apache/spark/pull/3801/files#diff-4


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org