You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2020/07/23 19:05:42 UTC
[GitHub] [trafficcontrol] rimashah25 opened a new pull request #4908: Updated documentation and TP's server UI related to xmppId
rimashah25 opened a new pull request #4908:
URL: https://github.com/apache/trafficcontrol/pull/4908
## What does this PR (Pull Request) do?
- This PR updated documentation related to xmppId and adds hashId field on Traffic Portal Server summary page.
## Which Traffic Control components are affected by this PR?
- Documentation
- Traffic Portal
## What is the best way to verify this PR?
1. Log into Traffic Portal UI
2. Go to configure/server tab.
3. Checkmark Hash ID from drop down list on top right corner, book button next to More.
4. Once checked, the field, Hash ID, should appear on the server summary page
## The following criteria are ALL met by this PR
- [x] I have explained why tests are unnecessary
- [x] This PR includes documentation
- [x] This PR includes an update to CHANGELOG.md
- [x] This PR includes any and all required license headers
- [x] This PR does not include a database migration
- [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
## Additional Information
This PR has no tests since it is a documentation and UI refactor PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a change in pull request #4908: Updated documentation and TP's server UI related to xmppId
Posted by GitBox <gi...@apache.org>.
rimashah25 commented on a change in pull request #4908:
URL: https://github.com/apache/trafficcontrol/pull/4908#discussion_r459764716
##########
File path: CHANGELOG.md
##########
@@ -26,6 +26,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Astats csv support - astats will now respond to `Accept: text/csv` and return a csv formatted stats list
- Updated /deliveryservices/{{ID}}/servers to use multiple interfaces in API v3
- Updated /deliveryservices/{{ID}}/servers/eligible to use multiple interfaces in API v3
+- Added the ability to view Hash ID field on Traffic Portals' server summary page
Review comment:
@mitchell852 Done!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 commented on a change in pull request #4908: Updated documentation and TP's server UI related to xmppId
Posted by GitBox <gi...@apache.org>.
mitchell852 commented on a change in pull request #4908:
URL: https://github.com/apache/trafficcontrol/pull/4908#discussion_r459678885
##########
File path: CHANGELOG.md
##########
@@ -26,6 +26,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Astats csv support - astats will now respond to `Accept: text/csv` and return a csv formatted stats list
- Updated /deliveryservices/{{ID}}/servers to use multiple interfaces in API v3
- Updated /deliveryservices/{{ID}}/servers/eligible to use multiple interfaces in API v3
+- Added the ability to view Hash ID field on Traffic Portals' server summary page
Review comment:
Can you maybe change this to:
```
Added the ability to view Hash ID field (aka xmppID) on Traffic Portals' server summary page
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] mitchell852 merged pull request #4908: Updated documentation and TP's server UI related to xmppId
Posted by GitBox <gi...@apache.org>.
mitchell852 merged pull request #4908:
URL: https://github.com/apache/trafficcontrol/pull/4908
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a change in pull request #4908: Updated documentation and TP's server UI related to xmppId
Posted by GitBox <gi...@apache.org>.
rimashah25 commented on a change in pull request #4908:
URL: https://github.com/apache/trafficcontrol/pull/4908#discussion_r459764716
##########
File path: CHANGELOG.md
##########
@@ -26,6 +26,7 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/).
- Astats csv support - astats will now respond to `Accept: text/csv` and return a csv formatted stats list
- Updated /deliveryservices/{{ID}}/servers to use multiple interfaces in API v3
- Updated /deliveryservices/{{ID}}/servers/eligible to use multiple interfaces in API v3
+- Added the ability to view Hash ID field on Traffic Portals' server summary page
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [trafficcontrol] rimashah25 commented on a change in pull request #4908: Updated documentation and TP's server UI related to xmppId
Posted by GitBox <gi...@apache.org>.
rimashah25 commented on a change in pull request #4908:
URL: https://github.com/apache/trafficcontrol/pull/4908#discussion_r461710328
##########
File path: traffic_portal/app/src/common/modules/table/servers/TableServersController.js
##########
@@ -93,6 +93,11 @@ var TableServersController = function(servers, $scope, $state, $uibModal, $windo
hide: true,
filter: "agNumberColumnFilter"
},
+ {
+ headerName: "Hash ID",
+ field: "xmppId",
+ hide: false
Review comment:
@mitchell852: Fixed here: https://github.com/apache/trafficcontrol/pull/4917/files
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org