[GitHub] [hudi] codope commented on a diff in pull request #6235: [HUDI-4493] Fixing handling of corrupt rollback plans

[GitBox <gi...@apache.org>]

codope commented on code in PR #6235:
URL: https://github.com/apache/hudi/pull/6235#discussion_r932238047


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java:
##########
@@ -1120,21 +1120,26 @@ protected Map<String, Option<HoodiePendingRollbackInfo>> getPendingRollbackInfos
       HoodieRollbackPlan rollbackPlan;
       try {
         rollbackPlan = RollbackUtils.getRollbackPlan(metaClient, rollbackInstant);
-      } catch (Exception e) {
-        if (rollbackInstant.isRequested()) {
-          LOG.warn("Fetching rollback plan failed for " + rollbackInstant + ", deleting the plan since it's in REQUESTED state", e);
-          try {
-            metaClient.getActiveTimeline().deletePending(rollbackInstant);
-          } catch (HoodieIOException he) {
-            LOG.warn("Cannot delete " + rollbackInstant, he);
-            continue;
+      } catch (IOException ioe) {
+        if (ioe.getMessage().contains("Not an Avro data file")) {

Review Comment:
   Relying on an exception message can be problematic as it can change across versions. Is there another way? Might not be.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org