You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by al...@apache.org on 2021/06/15 09:32:58 UTC
[dubbo] branch master updated: Add the file parameter to
MetadataReportBuilder (#8031)
This is an automated email from the ASF dual-hosted git repository.
albumenj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new ba4d88e Add the file parameter to MetadataReportBuilder (#8031)
ba4d88e is described below
commit ba4d88efb8b2ede66de0635cc24b4a1f245ee8e2
Author: 灼华 <43...@users.noreply.github.com>
AuthorDate: Tue Jun 15 04:32:44 2021 -0500
Add the file parameter to MetadataReportBuilder (#8031)
---
.../config/bootstrap/builders/MetadataReportBuilder.java | 11 +++++++++++
.../config/bootstrap/builders/MetadataReportBuilderTest.java | 10 +++++++++-
2 files changed, 20 insertions(+), 1 deletion(-)
diff --git a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/builders/MetadataReportBuilder.java b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/builders/MetadataReportBuilder.java
index 0e36eca..e82ab97 100644
--- a/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/builders/MetadataReportBuilder.java
+++ b/dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/bootstrap/builders/MetadataReportBuilder.java
@@ -60,6 +60,11 @@ public class MetadataReportBuilder extends AbstractBuilder<MetadataReportConfig,
*/
private Boolean syncReport;
+ /**
+ * File for saving metadata center dynamic list
+ */
+ private String file;
+
public static MetadataReportBuilder newBuilder() {
return new MetadataReportBuilder();
}
@@ -119,6 +124,11 @@ public class MetadataReportBuilder extends AbstractBuilder<MetadataReportConfig,
return getThis();
}
+ public MetadataReportBuilder file(String file) {
+ this.file = file;
+ return getThis();
+ }
+
public MetadataReportConfig build() {
MetadataReportConfig metadataReport = new MetadataReportConfig();
super.build(metadataReport);
@@ -133,6 +143,7 @@ public class MetadataReportBuilder extends AbstractBuilder<MetadataReportConfig,
metadataReport.setRetryPeriod(retryPeriod);
metadataReport.setCycleReport(cycleReport);
metadataReport.setSyncReport(syncReport);
+ metadataReport.setFile(file);
return metadataReport;
}
diff --git a/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/bootstrap/builders/MetadataReportBuilderTest.java b/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/bootstrap/builders/MetadataReportBuilderTest.java
index 5d60dd8..d40ba2f 100644
--- a/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/bootstrap/builders/MetadataReportBuilderTest.java
+++ b/dubbo-config/dubbo-config-api/src/test/java/org/apache/dubbo/config/bootstrap/builders/MetadataReportBuilderTest.java
@@ -124,10 +124,17 @@ class MetadataReportBuilderTest {
}
@Test
+ void file() {
+ MetadataReportBuilder builder = new MetadataReportBuilder();
+ builder.file("/tmp");
+ Assertions.assertEquals(builder.build().getFile(),"/tmp");
+ }
+
+ @Test
void build() {
MetadataReportBuilder builder = new MetadataReportBuilder();
builder.address("address").username("username").password("password").timeout(1000).group("group")
- .retryTimes(1).retryPeriod(2).cycleReport(true).syncReport(false)
+ .retryTimes(1).retryPeriod(2).cycleReport(true).syncReport(false).file("file")
.appendParameter("default.num", "one").id("id").prefix("prefix");
MetadataReportConfig config = builder.build();
@@ -142,6 +149,7 @@ class MetadataReportBuilderTest {
Assertions.assertEquals("username", config.getUsername());
Assertions.assertEquals("password", config.getPassword());
Assertions.assertEquals("group", config.getGroup());
+ Assertions.assertEquals("file", config.getFile());
Assertions.assertTrue(config.getParameters().containsKey("default.num"));
Assertions.assertEquals("one", config.getParameters().get("default.num"));
Assertions.assertEquals("id", config.getId());