[GitHub] spark pull request #14371: [SPARK-16736] WiP Core+ SQL superfluous fs calls

[vanzin <gi...@git.apache.org>]

Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14371#discussion_r73765083
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/state/HDFSBackedStateStoreProvider.scala ---
    @@ -278,14 +278,15 @@ private[state] class HDFSBackedStateStoreProvider(
     
       /** Initialize the store provider */
       private def initialize(): Unit = {
    -    if (!fs.exists(baseDir)) {
    -      fs.mkdirs(baseDir)
    -    } else {
    -      if (!fs.isDirectory(baseDir)) {
    +    try {
    +      if (!fs.getFileStatus(baseDir).isDirectory()) {
    --- End diff --
    
    Following the pattern, shouldn't the logic be inverted here?
    
    - try to mkdir
    - if it fails, re-throw with an informative message



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org