You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/09/02 18:37:26 UTC

[GitHub] [geode] DonalEvans commented on a change in pull request #6832: GEODE:9556: make GETSET a supported command

DonalEvans commented on a change in pull request #6832:
URL: https://github.com/apache/geode/pull/6832#discussion_r701322130



##########
File path: geode-apis-compatible-with-redis/src/main/java/org/apache/geode/redis/internal/RedisCommandType.java
##########
@@ -187,6 +187,7 @@
   SET(new SetExecutor(), SUPPORTED, new MinimumParameterRequirements(3)),
   SETNX(new SetNXExecutor(), SUPPORTED, new ExactParameterRequirements(3)),
   STRLEN(new StrlenExecutor(), SUPPORTED, new ExactParameterRequirements(2)),
+  GETSET(new GetSetExecutor(), SUPPORTED, new ExactParameterRequirements(3)),

Review comment:
       Could this be moved to between `GET` and `INCRBY` to preserve the alphabetical ordering of commands?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org