[GitHub] [incubator-druid] jihoonson opened a new pull request #8236: Add TaskResourceCleaner; fix a couple of concurrency bugs in batch tasks

[GitBox <gi...@apache.org>]

jihoonson opened a new pull request #8236: Add TaskResourceCleaner; fix a couple of concurrency bugs in batch tasks
URL: https://github.com/apache/incubator-druid/pull/8236
 
 
   ### Description
   
   There are a couple of bugs in `CompactionTask` and `ParallelIndexSubTask`. In `CompactionTask`, the current running indexTask should be killed when the compactionTask is killed. In `ParallelIndexSubTask`, I think [this line](https://github.com/apache/incubator-druid/blob/master/indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSubTask.java#L433) should be in the synchronized block.
   
   To reduce both of the possibility of mistakes and duplicate codes, I added a couple of helper methods to `AbstractBatchIndexTask`. I also removed the default implementation of `stopGracefully()` because it's now should be called properly for all production tasks.
   
   <hr>
   
   This PR has:
   - [x] been self-reviewed.
      - [x] using the [concurrency checklist](https://github.com/apache/incubator-druid/blob/master/dev/code-review/concurrency.md) (Remove this item if the PR doesn't have any relation to concurrency.)
   - [x] added Javadocs for most classes and all non-trivial methods. Linked related entities via Javadoc links.
   - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org