You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/02/20 01:17:18 UTC
[jira] [Commented] (THRIFT-3651) Make backports.match_hostname and
ipaddress optional
[ https://issues.apache.org/jira/browse/THRIFT-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15155198#comment-15155198 ]
ASF GitHub Bot commented on THRIFT-3651:
----------------------------------------
GitHub user nsuke opened a pull request:
https://github.com/apache/thrift/pull/880
THRIFT-3651 Make backports.match_hostname and ipaddress optional
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nsuke/thrift THRIFT-3651
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/thrift/pull/880.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #880
----
commit 08bcfb7c0fbf653db45ef38c5936228212f0346e
Author: Nobuaki Sukegawa <ns...@apache.org>
Date: 2016-02-19T23:51:33Z
THRIFT-3651 Make backports.match_hostname and ipaddress optional
----
> Make backports.match_hostname and ipaddress optional
> ----------------------------------------------------
>
> Key: THRIFT-3651
> URL: https://issues.apache.org/jira/browse/THRIFT-3651
> Project: Thrift
> Issue Type: Improvement
> Components: Python - Library
> Affects Versions: 0.10.0
> Reporter: Aki Sukegawa
> Assignee: Aki Sukegawa
> Fix For: 0.10.0
>
>
> THRIFT-3599 requires backports.match_hostname and ipaddress modules.
> I've modified the import logic so that TSSLSocket is usable without these.
> If the user is on Python 2.X and also either of above modules are absent:
> * client cert cannot be enabled and results in constructor exception
> * server cert validation logic falls back to legacy Thrift 0.9.3 version
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)