You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by gi...@git.apache.org on 2017/09/26 02:57:52 UTC

[GitHub] vongosling commented on a change in pull request #127: [ROCKETMQ-233] Fix pull interval issue

vongosling commented on a change in pull request #127: [ROCKETMQ-233] Fix pull interval issue
URL: https://github.com/apache/incubator-rocketmq/pull/127#discussion_r140947183
 
 

 ##########
 File path: client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImpl.java
 ##########
 @@ -273,6 +273,17 @@ public void pullMessage(final PullRequest pullRequest) {
         final long beginTimestamp = System.currentTimeMillis();
 
         PullCallback pullCallback = new PullCallback() {
+
+            private void scheduleNextPull(PullResult pullResult) {
 
 Review comment:
   correctTagsOffsetAndSchedulePull is not a good method.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services