[GitHub] [streampipes] bossenti commented on a diff in pull request #876: Add ci job for formatting and linting

[GitBox <gi...@apache.org>]

bossenti commented on code in PR #876:
URL: https://github.com/apache/streampipes/pull/876#discussion_r1054684560


##########
.github/workflows/pr-validation.yml:
##########
@@ -34,6 +34,30 @@ jobs:
       - name: Validate java code
         run: mvn clean verify -Dmaven.test.skip=true
 
+  run-format-and-lint-ui:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v1
+      
+      - name: Set up Node
+        uses: actions/setup-node@v1
+        with:
+          node-version: '16.x'
+
+      - name: Install dependencies
+        working-directory: ./ui
+        run: |
+          NODE_PATH=/cache/node_modules
+          NODE_OPTIONS=--max_old_space_size=6096
+          npm install --unsafe-perm --legacy-peer-deps
+
+      - name: Format and Lint all files
+        working-directory: ./ui
+        run: |
+          npm run format
+          npm run lint
+
   run-cypress-e2e-tests:
     runs-on: ubuntu-latest
     needs: [python-quality-checks, python-unit-tests]

Review Comment:
   please add `run-format-and-lint-ui` here



##########
ui/.prettierignore:
##########
@@ -0,0 +1,51 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+dist
+.angular
+
+# Remove these in the future to format additional modules
+# Please also see .eslintignore
+cypress

Review Comment:
   I have created #877 to track the progress



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org