You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "hujun260 (via GitHub)" <gi...@apache.org> on 2023/08/10 05:29:03 UTC

[GitHub] [nuttx] hujun260 opened a new pull request, #10147: drivers/input: rm sched_[un]lock

hujun260 opened a new pull request, #10147:
URL: https://github.com/apache/nuttx/pull/10147

   ## Summary
   rm sched_[un]lock
   
   ## Impact
   none
   ## Testing
   none
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] acassis commented on pull request #10147: drivers/input: rm sched_[un]lock

Posted by "acassis (via GitHub)" <gi...@apache.org>.
acassis commented on PR #10147:
URL: https://github.com/apache/nuttx/pull/10147#issuecomment-1673778820

   sched_[un]lock and enter_critical_section() doing same thing? If so, please include some comment in the commit message


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #10147: drivers/input: rm sched_[un]lock

Posted by "pkarashchenko (via GitHub)" <gi...@apache.org>.
pkarashchenko commented on code in PR #10147:
URL: https://github.com/apache/nuttx/pull/10147#discussion_r1292360567


##########
drivers/input/stmpe811_tsc.c:
##########
@@ -239,12 +239,13 @@ static inline int stmpe811_waitsample(FAR struct stmpe811_dev_s *priv,
                                       FAR struct stmpe811_sample_s *sample)
 {
   int ret;
+  irqstate_t flags;
 
   /* Disable pre-emption to prevent the worker thread from running
    * asynchronously.
    */
 
-  sched_lock();
+  flags = enter_critical_section();

Review Comment:
   The comment above does not reflect the actual state of things.
   
   Also this completely destroys the assumption in comment below



##########
drivers/input/ads7843e.c:
##########
@@ -372,7 +372,6 @@ static int ads7843e_waitsample(FAR struct ads7843e_dev_s *priv,
    * from getting control while we muck with the semaphores.
    */
 
-  sched_lock();

Review Comment:
   Please remove part of the related comment above



##########
drivers/input/max11802.c:
##########
@@ -329,7 +329,6 @@ static int max11802_waitsample(FAR struct max11802_dev_s *priv,
    * from getting control while we muck with the semaphores.
    */
 
-  sched_lock();

Review Comment:
   Ditto



##########
drivers/input/tsc2007.c:
##########
@@ -331,7 +331,6 @@ static int tsc2007_waitsample(FAR struct tsc2007_dev_s *priv,
    * from getting control while we muck with the semaphores.
    */
 
-  sched_lock();

Review Comment:
   Ditto for both comments above and below



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nuttx] xiaoxiang781216 merged pull request #10147: drivers/input: rm sched_[un]lock

Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #10147:
URL: https://github.com/apache/nuttx/pull/10147


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org