You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/05 13:11:20 UTC
[jira] [Commented] (KAFKA-4123) RocksDBStore can be marked as open
before it has been initialized
[ https://issues.apache.org/jira/browse/KAFKA-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15464970#comment-15464970 ]
ASF GitHub Bot commented on KAFKA-4123:
---------------------------------------
GitHub user dguy opened a pull request:
https://github.com/apache/kafka/pull/1824
KAFKA-4123: RocksDBStore can be marked as open before it has been initialized
Mark the store as open after the DB has been restored from the changelog.
Only add the store to the map in ProcessorStateManager post restore.
Make RocksDBWindowStore.Segment override openDB(..) as it needs to mark the Segment as open
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dguy/kafka kafka-4123
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1824.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1824
----
commit 43134b939e3a16310084dd203863c0ca73c4e5bd
Author: Damian Guy <da...@gmail.com>
Date: 2016-09-05T13:06:39Z
only mark store as open after it has been initialized. Add store to map in state manager post initiliazation
----
> RocksDBStore can be marked as open before it has been initialized
> -----------------------------------------------------------------
>
> Key: KAFKA-4123
> URL: https://issues.apache.org/jira/browse/KAFKA-4123
> Project: Kafka
> Issue Type: Bug
> Components: streams
> Affects Versions: 0.10.1.0
> Reporter: Damian Guy
> Assignee: Damian Guy
> Fix For: 0.10.1.0
>
>
> A RocksDBStore instance is currently marked as open before the store has been initialized from its changelog. This can result in reading old/invalid data when querying.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)