You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Martin Grigorov (JIRA)" <ji...@apache.org> on 2014/01/16 15:33:20 UTC
[jira] [Resolved] (WICKET-4697) Autolinking not working as soon as
component gets a wicket:id
[ https://issues.apache.org/jira/browse/WICKET-4697?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-4697.
-------------------------------------
Resolution: Fixed
Fix Version/s: 7.0.0
6.14.0
Assignee: Martin Grigorov (was: Carl-Eric Menzel)
Added a new constructor to ContextImage that has a single parameter - the component id.
The url for the 'src' attribute is read from the markup and relativized to the context root.
So instead of using WebMarkupContainer you should use ContextImage("someId").
> Autolinking not working as soon as component gets a wicket:id
> -------------------------------------------------------------
>
> Key: WICKET-4697
> URL: https://issues.apache.org/jira/browse/WICKET-4697
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5.7
> Reporter: Matthias Keller
> Assignee: Martin Grigorov
> Fix For: 6.14.0, 7.0.0
>
> Attachments: WICKET-4697.zip
>
>
> While migrating from 1.4.X, we encounter a lot of pages having an image with a relative URL set in the HTML, for example <img src="img/logo.gif"/>.
> Now on some pages, those images need to be references, mainly to alter the visibility logic or add an attribute modifier of some kind. Now as soon as we do
> <img wicket:id="logo" src="img/logo.gif"/>
> and add it using add(new WebMarkupContainer("logo")) , autolinking does not work anymore and the src is left as-is.
> Moving all sources to the java files and use ContextImage etc is no real option as this would be a *lot* of work and wouldn't make the html readable anymore as it would become hard to find all references to the images and also isn't logical to have the URL in the java files even though it's static and doesn't change.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)