You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/01/17 11:41:56 UTC
[GitHub] [ozone] lamber-ken opened a new pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
lamber-ken opened a new pull request #1812:
URL: https://github.com/apache/ozone/pull/1812
## What changes were proposed in this pull request?
In ozone/interface-client module, sources files are generated by protobuf plugin. But when other modules depend on this module, idea always prompts "Cannot resolve symbol" message.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-4713
## How was this patch tested?
Intellig IDEA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lamber-ken commented on pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on pull request #1812:
URL: https://github.com/apache/ozone/pull/1812#issuecomment-762813248
ok, thanks @amaliujia : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lamber-ken commented on pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on pull request #1812:
URL: https://github.com/apache/ozone/pull/1812#issuecomment-761960542
> I found if run `mvn install` then the Intellij will be able to find such proto classes.
>
> Does this `build-helper-maven-plugin` help skipping the step of `mvn install` in command line (thus better)?
Hi, @amaliujia, `mvn install` seams not work in my local machines(at least two computers, withing Intellij IDEA Ultimate 2020.3).
When using `build-helper-maven-plugin`, Intellij Idea works ok (need run mvn package )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1812:
URL: https://github.com/apache/ozone/pull/1812#issuecomment-762443840
Though I haven't checked what `build-helper-maven-plugin` does, I believe Intellij does not require to manually mark those source directories (at least on version 2020) :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia edited a comment on pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
amaliujia edited a comment on pull request #1812:
URL: https://github.com/apache/ozone/pull/1812#issuecomment-762087883
Actually I guess there are two things you can try:
1. Mark the directory as the generated source by intellij
2. It is possible that the intellij has marked the generated source, however the file size limit parameter is too small thus intellij does not load the specific large class/java file (the generated proto file sometimes can be very large). In this case you can increase the file size limit of the intellij.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1812:
URL: https://github.com/apache/ozone/pull/1812#issuecomment-761948160
I found if run `mvn install` then the Intellij will be able to find such proto classes.
Does this `build-helper-maven-plugin` skip the step of `mvn install` in command line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lamber-ken edited a comment on pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on pull request #1812:
URL: https://github.com/apache/ozone/pull/1812#issuecomment-761960542
> I found if run `mvn install` then the Intellij will be able to find such proto classes.
>
> Does this `build-helper-maven-plugin` help skipping the step of `mvn install` in command line (thus better)?
Hi, @amaliujia, `mvn install` seams not work in my local machines(at least two computers, withing Intellij IDEA Ultimate 2020.3).
When using `build-helper-maven-plugin`, Intellij Idea works ok (need run mvn package )
### Without build helper maven plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lamber-ken edited a comment on pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on pull request #1812:
URL: https://github.com/apache/ozone/pull/1812#issuecomment-762813248
I'll try again, thanks @amaliujia : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lamber-ken edited a comment on pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on pull request #1812:
URL: https://github.com/apache/ozone/pull/1812#issuecomment-762125939
Thanks for your detail @amaliujia . You're right, we need increate the `idea.max.intellisense.filesize`.
By the way, if we use `build-helper-maven-plugin`, the idea will automatically recognizes the source files. It doesn't have to mark these directory manually, it's friendlly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lamber-ken edited a comment on pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on pull request #1812:
URL: https://github.com/apache/ozone/pull/1812#issuecomment-762125939
Thanks for your the detailed explanation @amaliujia . You're right, we need increate the `idea.max.intellisense.filesize`.
By the way, if we use `build-helper-maven-plugin`, the idea will automatically recognizes the source files. It doesn't have to mark these directory manually, it's friendlly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia commented on pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
amaliujia commented on pull request #1812:
URL: https://github.com/apache/ozone/pull/1812#issuecomment-762087883
Actually I guess there are two things you can try:
1. Mark the directory as the generated source by intellij
2. It is possible that the intellij has marked the generated source, however the file size parameter is too small thus intellij does not load the specific large class/java file (the generated proto file sometimes can be very large).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lamber-ken closed pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
lamber-ken closed pull request #1812:
URL: https://github.com/apache/ozone/pull/1812
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lamber-ken commented on pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
lamber-ken commented on pull request #1812:
URL: https://github.com/apache/ozone/pull/1812#issuecomment-762125939
Thanks for your detail @amaliujia . You're right, we need increate the `idea.max.intellisense.filesize`.
By the way, if we use `build-helper-maven-plugin`, the idea will automatically recognizes the source files.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia edited a comment on pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
amaliujia edited a comment on pull request #1812:
URL: https://github.com/apache/ozone/pull/1812#issuecomment-762443840
Though I haven't checked what `build-helper-maven-plugin` does, I believe Intellij does not require to manually mark those source directories (at least on version 2020) :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lamber-ken edited a comment on pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on pull request #1812:
URL: https://github.com/apache/ozone/pull/1812#issuecomment-761960542
> I found if run `mvn install` then the Intellij will be able to find such proto classes.
>
> Does this `build-helper-maven-plugin` help skipping the step of `mvn install` in command line (thus better)?
Hi, @amaliujia, `mvn install` seams not work in my local machines(at least two computers, withing Intellij IDEA Ultimate 2020.3).
When using `build-helper-maven-plugin`, Intellij Idea works ok (need run mvn package )
### without build helper maven plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] lamber-ken edited a comment on pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
lamber-ken edited a comment on pull request #1812:
URL: https://github.com/apache/ozone/pull/1812#issuecomment-761960542
> I found if run `mvn install` then the Intellij will be able to find such proto classes.
>
> Does this `build-helper-maven-plugin` help skipping the step of `mvn install` in command line (thus better)?
Hi, @amaliujia, `mvn install` seams not work in my local machines(at least two computers, withing Intellij IDEA Ultimate 2020.3).
When using `build-helper-maven-plugin`, Intellij Idea works ok (need run mvn package )
### Without build-helper-maven-plugin
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] amaliujia edited a comment on pull request #1812: HDDS-4713. Add build-helper-maven-plugin to interface-client module
Posted by GitBox <gi...@apache.org>.
amaliujia edited a comment on pull request #1812:
URL: https://github.com/apache/ozone/pull/1812#issuecomment-761948160
I found if run `mvn install` then the Intellij will be able to find such proto classes.
Does this `build-helper-maven-plugin` help skipping the step of `mvn install` in command line (thus better)?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org