You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by mi...@gmail.com on 2011/10/05 20:40:55 UTC
Review Request: HIVE-2484: Improve ALTER TABLE SET SERDE to work on
partition level
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2215/
-----------------------------------------------------------
Review request for hive and Yongqiang He.
Summary
-------
Allowed ALTER TABLE SET SERDE and ALTER TABLE SET SERDEPROPERTIES to accept the PARTITION qualifier to work on a specific partition.
This addresses bug HIVE-2484.
https://issues.apache.org/jira/browse/HIVE-2484
Diffs
-----
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1178944
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1178944
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1178944
trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1178944
trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 1178984
trunk/ql/src/test/queries/clientpositive/alter_table_serde.q PRE-CREATION
trunk/ql/src/test/results/clientpositive/alter_table_serde.q.out PRE-CREATION
Diff: https://reviews.apache.org/r/2215/diff
Testing
-------
Thanks,
xiaol
Re: Review Request: HIVE-2484: Improve ALTER TABLE SET SERDE to work on
partition level
Posted by Yongqiang He <he...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2215/#review2362
-----------------------------------------------------------
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/2215/#comment5422>
code format here.
trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java
<https://reviews.apache.org/r/2215/#comment5424>
dup this line and move them to if (part!=null){} and else{}
- Yongqiang
On 2011-10-05 18:40:55, xiaol wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2215/
> -----------------------------------------------------------
>
> (Updated 2011-10-05 18:40:55)
>
>
> Review request for hive and Yongqiang He.
>
>
> Summary
> -------
>
> Allowed ALTER TABLE SET SERDE and ALTER TABLE SET SERDEPROPERTIES to accept the PARTITION qualifier to work on a specific partition.
>
>
> This addresses bug HIVE-2484.
> https://issues.apache.org/jira/browse/HIVE-2484
>
>
> Diffs
> -----
>
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 1178944
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 1178944
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 1178944
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzerFactory.java 1178944
> trunk/ql/src/java/org/apache/hadoop/hive/ql/plan/HiveOperation.java 1178984
> trunk/ql/src/test/queries/clientpositive/alter_table_serde.q PRE-CREATION
> trunk/ql/src/test/results/clientpositive/alter_table_serde.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/2215/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> xiaol
>
>