You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "ganigurgah (via GitHub)" <gi...@apache.org> on 2026/05/29 13:57:38 UTC
[PR] Add WebLogic 14.x and 15.x server support [netbeans]
ganigurgah opened a new pull request, #9414:
URL: https://github.com/apache/netbeans/pull/9414
Fixes #6109
**Issue**
NetBeans WebLogic plugin did not recognize WebLogic 14.x and 15.x installations as supported versions and did not offer them as deployment targets for Jakarta EE projects.
**Fix**
- WebLogicLayout.isSupportedVersion(): replaced hardcoded version whitelist with isAboveOrEqual("9.0.0.0") so future versions are supported without code changes
- WLDeploymentFactory: added VERSION_1411 and VERSION_1511 constants
---
**^Add meaningful description above**
<details open>
<summary>Click to collapse/expand PR instructions</summary>
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull request" so that the right test jobs can run.
### PR approval and merge checklist:
1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=240884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)),
did the right tests run? When did they run?
2. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NETBEANS/git%3A+squash+and+merge)?
3. [ ] Are author name / email address correct? Are [co-authors](https://doc/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-co-authored-commits-on-the-command-line) correctly listed? Do the commit messages need updates?
3. [ ] Does the PR title and description still fit after the Nth iteration? Is the description sufficient to appear in the release notes?
If this PR targets the delivery branch: [don't merge](https://cwiki.apache.oS/Pull+requests+for+delivery). ([full wikiarticle](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+A+reviewer+Guide))
</details>
sence değiştirmelimiyim ?
Commit mesajından otomatik doldurulmuş, içerik zaten doğru. Ben şunu değişti
1. --- ve altındaki ^Add meaningful description above satırını sil — bu template kalıntısı, PR'da görünmemeli.
2. <details> bloğunu olduğu gibi bırak — bu Apache NetBeans'in standart PR şablonu, reviewerlar için gerekli.
Yani sadece şu kısmı temizle:
(boş satır)
---
**^Add meaningful description above**
Geri kalan her şey uygun.
✻ Cooked for 10s
❯ tüm sayfaya copy/paste yapacağım şekilde hazırla
Fixes #6109
**Issue**
NetBeans WebLogic plugin did not recognize WebLogic 14.x and 15.x installations as supported versions and did not offer them as deployment targets for Jakarta EE projects.
**Fix**
- WebLogicLayout.isSupportedVersion(): replaced hardcoded version whitelist with isAboveOrEqual("9.0.0.0") so future versions are supported without code changes
- WLDeploymentFactory: added VERSION_1411 and VERSION_1511 constants
- WLJ2eePlatformFactory: added Java EE 8, Jakarta EE 8, Jakarta EE 9, 9.1, 10 and 11 profile support for WebLogic 14+ and 15+; added JDK 11 and 17 as supported Java versions for WebLogic 14+ and 15+
- BaseDescriptorModel: added VERSION_14_1_1 constant
- WebLogicLayoutTest: added test coverage for versions 14.x and 15.x
- Bumped javac.source to 11 which is the minimum required by WebLogic 14.x; this also fixes a build error caused by InputStream.transferTo() not being available at source level 1.8
<details open>
<summary>Click to collapse/expand PR instructions</summary>
By opening a pull request you confirm that, unless explicitly stated otherwise, the changes -
- are all your own work, and you have the right to contribute them.
- are contributed solely under the terms and conditions of the Apache License 2.0 (see section 5 of the license for more information).
Please make sure (eg. `git log`) that all commits have a valid name and email address for you in the Author field.
If you're a first time contributor, see the Contributing guidelines for more information.
If you're a committer, please label the PR before pressing "Create pull requobs can run.
### PR approval and merge checklist:
1. [ ] Was this PR [correctly labeled](https://cwiki.apache.org/confluence/p40884239#PRsandYouAreviewerGuide-PRtriggeredCIJobs(conditionalCIpipeline)),
did the right tests run? When did they run?
2. [ ] Is this PR [squashed](https://cwiki.apache.org/confluence/display/NET)?3. [ ] Are author name / email address correct? Are [co-authors](https://doc/committing-changes-to-your-project/creating-and-editing-commits/creating-a-commit-with-multiple-authors#creating-a-commit-with-multiple-authors) correctlges need updates?3. [ ] Does the PR title and description still fit after the Nth iteration? to appear in the release notes?If this PR targets the delivery branch: [don't merge](https://cwiki.apache.oS/Pull+requests+for+delivery). ([full wikiarticle](https://cwiki.apache.org/confluence/display/NETBEANS/PRs+and+You+-+
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add WebLogic 14.x and 15.x server support [netbeans]
Posted by "ganigurgah (via GitHub)" <gi...@apache.org>.
ganigurgah closed pull request #9414: Add WebLogic 14.x and 15.x server support
URL: https://github.com/apache/netbeans/pull/9414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add WebLogic 14.x and 15.x server support [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #9414:
URL: https://github.com/apache/netbeans/pull/9414#discussion_r3424355144
##########
contrib/j2ee.weblogic9/src/org/netbeans/modules/j2ee/weblogic9/dd/model/BaseDescriptorModel.java:
##########
@@ -45,6 +45,8 @@ public class BaseDescriptorModel {
protected static final Version VERSION_12_1_1 = Version.fromJsr277NotationWithFallback("12.1.1"); // NOI18N
protected static final Version VERSION_12_2_1 = Version.fromJsr277NotationWithFallback("12.2.1"); // NOI18N
+
+ protected static final Version VERSION_14_1_1 = Version.fromJsr277NotationWithFallback("14.1.1"); // NOI18N
Review Comment:
this doesn't appear to be used.
this indicates that either:
- the three generate methods in the model classes `EjbJarModel`, `EarApplicationModel` and `WebApplicationModel` need to be updated
- or update is not needed and the constant can be removed if the emitted code is OK for the version
##########
contrib/j2ee.weblogic9/src/org/netbeans/modules/j2ee/weblogic9/j2ee/WLJ2eePlatformFactory.java:
##########
@@ -130,6 +130,10 @@ public class WLJ2eePlatformFactory extends J2eePlatformFactory {
private static final Version JDK8_SUPPORTED_SERVER_VERSION = Version.fromJsr277NotationWithFallback("12.1.3"); // NOI18N
+ private static final Version JDK11_SUPPORTED_SERVER_VERSION = Version.fromJsr277NotationWithFallback("14.1.1"); // NOI18N
+
+ private static final Version JDK17_SUPPORTED_SERVER_VERSION = Version.fromJsr277NotationWithFallback("15.1.1"); // NOI18N
Review Comment:
seems to be correct
- https://docs.oracle.com/en/middleware/standalone/weblogic-server/14.1.1.0/notes/whatsnew.html#GUID-960100E8-DFC1-49E5-8CED-1EC1D883A42F
- https://docs.oracle.com/en/middleware/standalone/weblogic-server/15.1.1/notes/whatsnew.html#GUID-B6E42F6B-3C3C-4332-A064-DE14CD1A7E5C
but the versioning scheme is a bit wild, e.g it seems like 14.1.2 also supports 17 and 21
- https://docs.oracle.com/en/middleware/fusion-middleware/weblogic-server/14.1.2/notes/whatsnew.html#GUID-DF8CFD1C-9DD1-423E-ACA6-9717D5738385
might not be super important though, worst case is that JDK 11 will show up on a lower version in the combo box I suppose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add WebLogic 14.x and 15.x server support [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on code in PR #9414:
URL: https://github.com/apache/netbeans/pull/9414#discussion_r3325372377
##########
contrib/j2ee.weblogic9/nbproject/project.properties:
##########
@@ -17,7 +17,7 @@
# under the License.
#
-javac.source=1.8
+javac.source=11
Review Comment:
please switch to `javac.release`. plus: The NB project can use 21 now, assuming tests pass.
feel free to edit the commit and force push
##########
contrib/j2ee.weblogic9/src/org/netbeans/modules/j2ee/weblogic9/deploy/WLJpa2SwitchSupport.java:
##########
@@ -397,7 +397,11 @@ private void createContributionsJar(File jarFile, String classpath) throws IOExc
private void copy(File source, File dest) throws IOException {
try (InputStream is = new BufferedInputStream(new FileInputStream(source));
OutputStream os = new BufferedOutputStream(new FileOutputStream(dest))) {
- is.transferTo(os);
+ byte[] buf = new byte[4096];
+ int n;
+ while ((n = is.read(buf)) != -1) {
+ os.write(buf, 0, n);
+ }
Review Comment:
please revert too
##########
contrib/j2ee.weblogic9/src/org/netbeans/modules/j2ee/weblogic9/deploy/WLDriverDeployer.java:
##########
@@ -114,7 +114,11 @@ public void run() {
ActionType.EXECUTE, CommandType.DISTRIBUTE, StateType.RUNNING,
NbBundle.getMessage(WLDriverDeployer.class, "MSG_DeployingJDBCDrivers", toJar.getPath())));
try (BufferedOutputStream os = new BufferedOutputStream(new FileOutputStream(toJar))) {
- is.transferTo(os);
+ byte[] buf = new byte[4096];
+ int n;
+ while ((n = is.read(buf)) != -1) {
+ os.write(buf, 0, n);
+ }
Review Comment:
unclear why this was changed. This does not appear to require jdk 8 target.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add WebLogic 14.x and 15.x server support [netbeans]
Posted by "ganigurgah (via GitHub)" <gi...@apache.org>.
ganigurgah commented on PR #9414:
URL: https://github.com/apache/netbeans/pull/9414#issuecomment-4588234464
Thanks for the review @mbien Addressed all three:
- switched to javac.release=21
- reverted both transferTo changes
Force-pushed the amended commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
Re: [PR] Add WebLogic 14.x and 15.x server support [netbeans]
Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #9414:
URL: https://github.com/apache/netbeans/pull/9414#issuecomment-4696177927
@ganigurgah sorry for the delay, I wasn't available for various reasons. Will try to get to this soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists