[GitHub] sohami commented on a change in pull request #1531: DRILL-5571: Cancel running query from its Web UI

[GitBox <gi...@apache.org>]

sohami commented on a change in pull request #1531: DRILL-5571: Cancel running query from its Web UI
URL: https://github.com/apache/drill/pull/1531#discussion_r232521155
 
 

 ##########
 File path: exec/java-exec/src/main/resources/rest/profile/profile.ftl
 ##########
 @@ -171,7 +229,17 @@ table.sortable thead .sorting_desc { background-image: url("/static/img/black-de
   <#assign queued = queueName != "" && queueName != "-" />
 
   <div class="page-header"></div>
-  <h3>Query Profile : <span style='font-size:85%'>${model.getQueryId()}</span></h3>
+  <h3>Query Profile : <span style='font-size:85%'>${model.getQueryId()}</span>
+  <#if model.getQueryStateDisplayName() == "Running" || model.getQueryStateDisplayName() == "Planning">
+  <div id="cancelPopup"  onclick="closePopup()">
+    <div id="cancelText" align="center">Issued cancellation for query<br>Click to continue</div>
+  </div>
+  <div  style="display: inline-block;">
+    <button type="button" class="btn btn-warning btn-sm" onClick="cancelQuery('${model.queryId}');">
+    <span class="glyphicon glyphicon-remove"></span> Cancel </button>  
 
 Review comment:
   Not to be picky but I would say for consistency use the same button format as in other pages like /storage tab.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services