You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2015/08/13 23:25:15 UTC
Review Request 37447: Making scheduler loop continue after mismatch.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37447/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Zameer Manji.
Bugs: AURORA-1435
https://issues.apache.org/jira/browse/AURORA-1435
Repository: aurora
Description
-------
Dropping the return statement that prematurely terminated scheduling loop on a first mismatch.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 14d70df1f86e87ccc299558326b69662af759d08
src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 1de1d1f11a57ac6f31f184d57776bc0d0256a901
Diff: https://reviews.apache.org/r/37447/diff/
Testing
-------
Thanks,
Maxim Khutornenko
Re: Review Request 37447: Making scheduler loop continue after
mismatch.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37447/#review95334
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On Aug. 13, 2015, 2:25 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37447/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 2:25 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
>
>
> Bugs: AURORA-1435
> https://issues.apache.org/jira/browse/AURORA-1435
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping the return statement that prematurely terminated scheduling loop on a first mismatch.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 14d70df1f86e87ccc299558326b69662af759d08
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 1de1d1f11a57ac6f31f184d57776bc0d0256a901
>
> Diff: https://reviews.apache.org/r/37447/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37447: Making scheduler loop continue after
mismatch.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37447/#review95336
-----------------------------------------------------------
Ship it!
Master (887ffd2) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Aug. 13, 2015, 9:25 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37447/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 9:25 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
>
>
> Bugs: AURORA-1435
> https://issues.apache.org/jira/browse/AURORA-1435
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping the return statement that prematurely terminated scheduling loop on a first mismatch.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 14d70df1f86e87ccc299558326b69662af759d08
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 1de1d1f11a57ac6f31f184d57776bc0d0256a901
>
> Diff: https://reviews.apache.org/r/37447/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>
Re: Review Request 37447: Making scheduler loop continue after
mismatch.
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37447/#review95332
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Aug. 13, 2015, 2:25 p.m., Maxim Khutornenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37447/
> -----------------------------------------------------------
>
> (Updated Aug. 13, 2015, 2:25 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Zameer Manji.
>
>
> Bugs: AURORA-1435
> https://issues.apache.org/jira/browse/AURORA-1435
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Dropping the return statement that prematurely terminated scheduling loop on a first mismatch.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/state/TaskAssigner.java 14d70df1f86e87ccc299558326b69662af759d08
> src/test/java/org/apache/aurora/scheduler/state/TaskAssignerImplTest.java 1de1d1f11a57ac6f31f184d57776bc0d0256a901
>
> Diff: https://reviews.apache.org/r/37447/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Maxim Khutornenko
>
>