[jira] [Commented] (FLINK-7897) Consider using nio.Files for file deletion in TransientBlobCleanupTask

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-7897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16416625#comment-16416625 ] 

ASF GitHub Bot commented on FLINK-7897:
---------------------------------------

GitHub user yanghua opened a pull request:

    https://github.com/apache/flink/pull/5777

    [FLINK-7897] Consider using nio.Files for file deletion in TransientBlobCleanupTask

    ## What is the purpose of the change
    
    *This pull request use `nio.Files.delete` method to make the delete failed reason more clear*
    
    
    ## Brief change log
    
      - *use nio.Files.delete static method to replace file#delete method*
    
    ## Verifying this change
    
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (yes / **no**)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
      - The serializers: (yes / **no** / don't know)
      - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
      - The S3 file system connector: (yes / **no** / don't know)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes / **no**)
      - If yes, how is the feature documented? (not applicable / docs / JavaDocs / **not documented**)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanghua/flink FLINK-7897

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5777.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5777
    
----

----


> Consider using nio.Files for file deletion in TransientBlobCleanupTask
> ----------------------------------------------------------------------
>
>                 Key: FLINK-7897
>                 URL: https://issues.apache.org/jira/browse/FLINK-7897
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>            Reporter: Ted Yu
>            Assignee: vinoyang
>            Priority: Minor
>
> nio.Files#delete() provides better clue as to why the deletion may fail:
> https://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#delete(java.nio.file.Path)
> Depending on the potential exception (FileNotFound), the call to localFile.exists() may be skipped.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)