Re: [PR] Adding complex expressions projections for Subquery [arrow-datafusion]

["andygrove (via GitHub)" <gi...@apache.org>]

andygrove commented on code in PR #9719:
URL: https://github.com/apache/arrow-datafusion/pull/9719#discussion_r1565949967


##########
datafusion/optimizer/src/common_subexpr_eliminate.rs:
##########
@@ -423,6 +417,34 @@ impl OptimizerRule for CommonSubexprEliminate {
             plan => Ok(plan),
         }
     }
+    /// currently the implemention is not optimal, Basically I just do a top-down iteration over all the

Review Comment:
   This comment seems to be incomplete?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org