You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Boris Shkolnik (JIRA)" <ji...@apache.org> on 2009/12/29 00:20:29 UTC
[jira] Created: (HADOOP-6472) add tokenCache option to
GenericOptionsParser for passing file with secret keys to a map reduce job
add tokenCache option to GenericOptionsParser for passing file with secret keys to a map reduce job
---------------------------------------------------------------------------------------------------
Key: HADOOP-6472
URL: https://issues.apache.org/jira/browse/HADOOP-6472
Project: Hadoop Common
Issue Type: New Feature
Reporter: Boris Shkolnik
for MAPRED-1338 - we need an option to pass a file with secreteKeys (tokens) to a mapreduce Job.
Name of the file is set into the config and will be picked up by JobSubmiter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6472) add tokenCache option to
GenericOptionsParser for passing file with secret keys to a map reduce job
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12795023#action_12795023 ]
Devaraj Das commented on HADOOP-6472:
-------------------------------------
Looks good. Some minor comments:
1) Remove the LOG.info calls
2) There seems to be an unused import in the testcase (org.apache.hadoop.record.Utils).
3) Some unnecessary whitespace changes in the testcase.
4) Maybe we should rename the "tokenCache" option to "tokenCacheFile" to make it more specific that it needs to be a file..
> add tokenCache option to GenericOptionsParser for passing file with secret keys to a map reduce job
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6472
> URL: https://issues.apache.org/jira/browse/HADOOP-6472
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6472.patch
>
>
> for MAPRED-1338 - we need an option to pass a file with secreteKeys (tokens) to a mapreduce Job.
> Name of the file is set into the config and will be picked up by JobSubmiter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6472) add tokenCache option to
GenericOptionsParser for passing file with secret keys to a map reduce job
Posted by "Sam Walker (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12874022#action_12874022 ]
Sam Walker commented on HADOOP-6472:
------------------------------------
Alpha Bravo Charlie
> add tokenCache option to GenericOptionsParser for passing file with secret keys to a map reduce job
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6472
> URL: https://issues.apache.org/jira/browse/HADOOP-6472
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6472-1.patch, HADOOP-6472-2.patch, HADOOP-6472.patch
>
>
> for MAPRED-1338 - we need an option to pass a file with secreteKeys (tokens) to a mapreduce Job.
> Name of the file is set into the config and will be picked up by JobSubmiter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6472) add tokenCache option to
GenericOptionsParser for passing file with secret keys to a map reduce job
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796623#action_12796623 ]
Hudson commented on HADOOP-6472:
--------------------------------
Integrated in Hadoop-Common-trunk #209 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/209/])
. add tokenCache option to GenericOptionsParser for passing
file with secret keys to a map reduce job. (boryas)
> add tokenCache option to GenericOptionsParser for passing file with secret keys to a map reduce job
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6472
> URL: https://issues.apache.org/jira/browse/HADOOP-6472
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6472-1.patch, HADOOP-6472-2.patch, HADOOP-6472.patch
>
>
> for MAPRED-1338 - we need an option to pass a file with secreteKeys (tokens) to a mapreduce Job.
> Name of the file is set into the config and will be picked up by JobSubmiter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6472) add tokenCache option to
GenericOptionsParser for passing file with secret keys to a map reduce job
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796398#action_12796398 ]
Hudson commented on HADOOP-6472:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #131 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/131/])
. add tokenCache option to GenericOptionsParser for passing
file with secret keys to a map reduce job. (boryas)
> add tokenCache option to GenericOptionsParser for passing file with secret keys to a map reduce job
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6472
> URL: https://issues.apache.org/jira/browse/HADOOP-6472
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6472-1.patch, HADOOP-6472-2.patch, HADOOP-6472.patch
>
>
> for MAPRED-1338 - we need an option to pass a file with secreteKeys (tokens) to a mapreduce Job.
> Name of the file is set into the config and will be picked up by JobSubmiter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6472) add tokenCache option to
GenericOptionsParser for passing file with secret keys to a map reduce job
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6472:
-----------------------------------
Attachment: HADOOP-6472-1.patch
addressed all the comments.
Also modified test to have setUp and tearDown methods.
> add tokenCache option to GenericOptionsParser for passing file with secret keys to a map reduce job
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6472
> URL: https://issues.apache.org/jira/browse/HADOOP-6472
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6472-1.patch, HADOOP-6472.patch
>
>
> for MAPRED-1338 - we need an option to pass a file with secreteKeys (tokens) to a mapreduce Job.
> Name of the file is set into the config and will be picked up by JobSubmiter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HADOOP-6472) add tokenCache option to
GenericOptionsParser for passing file with secret keys to a map reduce job
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik reassigned HADOOP-6472:
--------------------------------------
Assignee: Boris Shkolnik
> add tokenCache option to GenericOptionsParser for passing file with secret keys to a map reduce job
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6472
> URL: https://issues.apache.org/jira/browse/HADOOP-6472
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
>
> for MAPRED-1338 - we need an option to pass a file with secreteKeys (tokens) to a mapreduce Job.
> Name of the file is set into the config and will be picked up by JobSubmiter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6472) add tokenCache option to
GenericOptionsParser for passing file with secret keys to a map reduce job
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6472:
-----------------------------------
Attachment: HADOOP-6472.patch
> add tokenCache option to GenericOptionsParser for passing file with secret keys to a map reduce job
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6472
> URL: https://issues.apache.org/jira/browse/HADOOP-6472
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6472.patch
>
>
> for MAPRED-1338 - we need an option to pass a file with secreteKeys (tokens) to a mapreduce Job.
> Name of the file is set into the config and will be picked up by JobSubmiter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6472) add tokenCache option to
GenericOptionsParser for passing file with secret keys to a map reduce job
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6472:
-----------------------------------
Status: Patch Available (was: Open)
> add tokenCache option to GenericOptionsParser for passing file with secret keys to a map reduce job
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6472
> URL: https://issues.apache.org/jira/browse/HADOOP-6472
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6472-1.patch, HADOOP-6472.patch
>
>
> for MAPRED-1338 - we need an option to pass a file with secreteKeys (tokens) to a mapreduce Job.
> Name of the file is set into the config and will be picked up by JobSubmiter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6472) add tokenCache option to
GenericOptionsParser for passing file with secret keys to a map reduce job
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796345#action_12796345 ]
Hadoop QA commented on HADOOP-6472:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12429367/HADOOP-6472-1.patch
against trunk revision 895467.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 4 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/249/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/249/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/249/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/249/console
This message is automatically generated.
> add tokenCache option to GenericOptionsParser for passing file with secret keys to a map reduce job
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6472
> URL: https://issues.apache.org/jira/browse/HADOOP-6472
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6472-1.patch, HADOOP-6472.patch
>
>
> for MAPRED-1338 - we need an option to pass a file with secreteKeys (tokens) to a mapreduce Job.
> Name of the file is set into the config and will be picked up by JobSubmiter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6472) add tokenCache option to
GenericOptionsParser for passing file with secret keys to a map reduce job
Posted by "Owen O'Malley (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Owen O'Malley updated HADOOP-6472:
----------------------------------
Resolution: Fixed
Fix Version/s: 0.22.0
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
Nobody closed this when it was committed.
> add tokenCache option to GenericOptionsParser for passing file with secret keys to a map reduce job
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6472
> URL: https://issues.apache.org/jira/browse/HADOOP-6472
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Fix For: 0.22.0
>
> Attachments: HADOOP-6472-1.patch, HADOOP-6472-2.patch, HADOOP-6472.patch
>
>
> for MAPRED-1338 - we need an option to pass a file with secreteKeys (tokens) to a mapreduce Job.
> Name of the file is set into the config and will be picked up by JobSubmiter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6472) add tokenCache option to
GenericOptionsParser for passing file with secret keys to a map reduce job
Posted by "Devaraj Das (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12796380#action_12796380 ]
Devaraj Das commented on HADOOP-6472:
-------------------------------------
Looks good. +1
> add tokenCache option to GenericOptionsParser for passing file with secret keys to a map reduce job
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6472
> URL: https://issues.apache.org/jira/browse/HADOOP-6472
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6472-1.patch, HADOOP-6472-2.patch, HADOOP-6472.patch
>
>
> for MAPRED-1338 - we need an option to pass a file with secreteKeys (tokens) to a mapreduce Job.
> Name of the file is set into the config and will be picked up by JobSubmiter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6472) add tokenCache option to
GenericOptionsParser for passing file with secret keys to a map reduce job
Posted by "Boris Shkolnik (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Boris Shkolnik updated HADOOP-6472:
-----------------------------------
Attachment: HADOOP-6472-2.patch
changed File.getAbsolutePath() to File.toString()
removed some commented line
> add tokenCache option to GenericOptionsParser for passing file with secret keys to a map reduce job
> ---------------------------------------------------------------------------------------------------
>
> Key: HADOOP-6472
> URL: https://issues.apache.org/jira/browse/HADOOP-6472
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Boris Shkolnik
> Assignee: Boris Shkolnik
> Attachments: HADOOP-6472-1.patch, HADOOP-6472-2.patch, HADOOP-6472.patch
>
>
> for MAPRED-1338 - we need an option to pass a file with secreteKeys (tokens) to a mapreduce Job.
> Name of the file is set into the config and will be picked up by JobSubmiter.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.