You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Hisoka-X (via GitHub)" <gi...@apache.org> on 2023/05/28 12:14:28 UTC
[GitHub] [spark] Hisoka-X opened a new pull request, #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Hisoka-X opened a new pull request, #41348:
URL: https://github.com/apache/spark/pull/41348
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'core/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
In order to fix DROP table behavior in session catalog cause by #37879. Because we always invoke V1 drop logic if the identifier looks like a V1 identifier. This is a big blocker for external data sources that provide custom session catalogs.
So this PR move all Drop Table case to DataSource V2 (use drop table to drop view not include). More information please check https://github.com/apache/spark/pull/37879/files#r1170501180
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
3. If you fix some SQL features, you can provide some references of other DBMSes.
4. If there is design documentation, please add the link.
5. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
Move Drop Table case to DataSource V2 to fix bug and prepare for remove drop table v1.
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
No
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
Tested by:
- V2 table catalog tests: `org.apache.spark.sql.execution.command.v2.DropTableSuite`
- V1 table catalog tests: `org.apache.spark.sql.execution.command.v1.DropTableSuiteBase`
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #41348:
URL: https://github.com/apache/spark/pull/41348#issuecomment-1597123465
Thanks @cloud-fan @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #41348:
URL: https://github.com/apache/spark/pull/41348#issuecomment-1583654481
> Is the test failure related?
>
> ```
> DataFrameFunctionsSuite.DataFrame function and SQL functon parity
> org.scalatest.exceptions.TestFailedException: Set("ceiling", "negative", "std", "sign") was not empty
> ```
I think not, many PR can't pass sql - other tests at now. Seem ci have something wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1221284308
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala:
##########
@@ -194,12 +203,28 @@ class V2SessionCatalog(catalog: SessionCatalog)
}
override def dropTable(ident: Identifier): Boolean = {
+ dropTableInternal(ident)
+ }
+
+ private def dropTableInternal(ident: Identifier, purge: Boolean = false): Boolean = {
try {
- if (loadTable(ident) != null) {
+ val table = loadTable(ident)
+ if (table != null) {
+ val v1Table = table.asInstanceOf[V1Table].v1Table
Review Comment:
people can provide a custom v2 session and `loadTable` does not always return a v1 table. Can we do a pattern match here and only do the additional handling if it's a v1 table?
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala:
##########
@@ -194,12 +203,28 @@ class V2SessionCatalog(catalog: SessionCatalog)
}
override def dropTable(ident: Identifier): Boolean = {
+ dropTableInternal(ident)
+ }
+
+ private def dropTableInternal(ident: Identifier, purge: Boolean = false): Boolean = {
try {
- if (loadTable(ident) != null) {
+ val table = loadTable(ident)
+ if (table != null) {
+ val v1Table = table.asInstanceOf[V1Table].v1Table
Review Comment:
people can provide a custom v2 session catalog and `loadTable` does not always return a v1 table. Can we do a pattern match here and only do the additional handling if it's a v1 table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #41348:
URL: https://github.com/apache/spark/pull/41348#issuecomment-1566117620
cc @aokolnychyi @cloud-fan @viirya
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1212912891
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala:
##########
@@ -1072,6 +1072,8 @@ class HiveDDLSuite
}
test("drop view using drop table") {
+ assume(false, "This test fails because of DataSource V2 Drop Table not support " +
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1222590407
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/DropTableSuite.scala:
##########
@@ -26,7 +26,7 @@ class DropTableSuite extends v1.DropTableSuiteBase with CommandSuiteBase {
test("hive client calls") {
withNamespaceAndTable("ns", "tbl") { t =>
sql(s"CREATE TABLE $t (id int) $defaultUsing")
- checkHiveClientCalls(expected = 11) {
+ checkHiveClientCalls(expected = 10) {
Review Comment:
the v2 DROP TABLE command can save one PRC call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #41348:
URL: https://github.com/apache/spark/pull/41348#issuecomment-1583295230
Is the test failure related?
```
DataFrameFunctionsSuite.DataFrame function and SQL functon parity
org.scalatest.exceptions.TestFailedException: Set("ceiling", "negative", "std", "sign") was not empty
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1222862287
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala:
##########
@@ -194,12 +203,30 @@ class V2SessionCatalog(catalog: SessionCatalog)
}
override def dropTable(ident: Identifier): Boolean = {
+ dropTableInternal(ident)
+ }
+
+ private def dropTableInternal(ident: Identifier, purge: Boolean = false): Boolean = {
try {
- if (loadTable(ident) != null) {
+ val table = loadTable(ident)
+ if (table != null) {
Review Comment:
Just follow old code 😂. Changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1211433299
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala:
##########
@@ -691,22 +691,24 @@ class PlanResolutionSuite extends AnalysisTest {
test("drop table") {
val tableName1 = "db.v1Table"
- val tableIdent1 = TableIdentifier("v1Table", Option("db"), Some(SESSION_CATALOG_NAME))
+ val tableIdent1 = ResolvedIdentifier(v2SessionCatalog, new IdentifierImpl(Seq("db").toArray,
Review Comment:
We have `Identifier.of`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #41348:
URL: https://github.com/apache/spark/pull/41348#issuecomment-1588343168
@cloud-fan @viirya Hi folks, the CI passed. Can we move forward next step?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] aokolnychyi commented on pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "aokolnychyi (via GitHub)" <gi...@apache.org>.
aokolnychyi commented on PR #41348:
URL: https://github.com/apache/spark/pull/41348#issuecomment-1610313197
I unfortunately created this initially as improvement. It is actually a bug and regression, which breaks DROP in custom sessions catalogs. Can we include it in 3.4.2?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1211437714
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -210,9 +210,6 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
c
}
- case DropTable(ResolvedV1Identifier(ident), ifExists, purge) =>
Review Comment:
shall we support v1 fallback with `if conf.useV1Command`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1212865341
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala:
##########
@@ -1072,6 +1072,8 @@ class HiveDDLSuite
}
test("drop view using drop table") {
+ assume(false, "This test fails because of DataSource V2 Drop Table not support " +
Review Comment:
Can we update `V2SessionCatalog.dropTable` to do this check? We should not introduce behavior change here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1212891923
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala:
##########
@@ -71,7 +71,12 @@ class V2SessionCatalog(catalog: SessionCatalog)
}
override def loadTable(ident: Identifier): Table = {
- V1Table(catalog.getTableMetadata(ident.asTableIdentifier))
+ try {
+ V1Table(catalog.getTableMetadata(ident.asTableIdentifier))
+ } catch {
+ case _: NoSuchDatabaseException =>
Review Comment:
Yes, the `DerbyTableCatalogSuite:SPARK-42978: RENAME cannot qualify a new-table-Name with a schema-Name.` will failed without this change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #41348:
URL: https://github.com/apache/spark/pull/41348#issuecomment-1597119763
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1211614022
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/IdentifierImpl.java:
##########
@@ -30,12 +30,12 @@
* An {@link Identifier} implementation.
*/
@Evolving
-class IdentifierImpl implements Identifier {
+public class IdentifierImpl implements Identifier {
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1211613665
##########
sql/core/src/test/scala/org/apache/spark/sql/execution/command/PlanResolutionSuite.scala:
##########
@@ -691,22 +691,24 @@ class PlanResolutionSuite extends AnalysisTest {
test("drop table") {
val tableName1 = "db.v1Table"
- val tableIdent1 = TableIdentifier("v1Table", Option("db"), Some(SESSION_CATALOG_NAME))
+ val tableIdent1 = ResolvedIdentifier(v2SessionCatalog, new IdentifierImpl(Seq("db").toArray,
Review Comment:
Thanks for remind, fixed
##########
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala:
##########
@@ -210,9 +210,6 @@ class ResolveSessionCatalog(val catalogManager: CatalogManager)
c
}
- case DropTable(ResolvedV1Identifier(ident), ifExists, purge) =>
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1222869265
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala:
##########
@@ -194,12 +203,30 @@ class V2SessionCatalog(catalog: SessionCatalog)
}
override def dropTable(ident: Identifier): Boolean = {
+ dropTableInternal(ident)
+ }
+
+ private def dropTableInternal(ident: Identifier, purge: Boolean = false): Boolean = {
try {
- if (loadTable(ident) != null) {
+ val table = loadTable(ident)
+ if (table != null) {
Review Comment:
> Isn't it always returning V1Table?
Please check https://github.com/apache/spark/pull/41348#discussion_r1221284308
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1211424022
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/IdentifierImpl.java:
##########
@@ -30,12 +30,12 @@
* An {@link Identifier} implementation.
*/
@Evolving
-class IdentifierImpl implements Identifier {
+public class IdentifierImpl implements Identifier {
Review Comment:
This shouldn't be exposed as an API. Can we move it to the `org.apache.spark.sql.internal.connector` package and rewrite it with scala?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1222519333
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/connector/IdentifierImpl.scala:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.internal.connector
+
+import java.util.{Objects, StringJoiner}
+
+import org.apache.spark.annotation.Evolving
+import org.apache.spark.sql.catalyst.util.quoteIfNeeded
+import org.apache.spark.sql.connector.catalog.Identifier
+
+/**
+ * An {@link Identifier} implementation.
+ */
+@Evolving
+class IdentifierImpl(namespace: Array[String], name: String)
Review Comment:
Why moving this from java to scala? Looks like the API is same?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1222524168
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala:
##########
@@ -194,12 +203,30 @@ class V2SessionCatalog(catalog: SessionCatalog)
}
override def dropTable(ident: Identifier): Boolean = {
+ dropTableInternal(ident)
+ }
+
+ private def dropTableInternal(ident: Identifier, purge: Boolean = false): Boolean = {
try {
- if (loadTable(ident) != null) {
+ val table = loadTable(ident)
+ if (table != null) {
Review Comment:
Hmm, is it possibly `loadTable` returning null? Isn't it always returning `V1Table`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1222525215
##########
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/command/DropTableSuite.scala:
##########
@@ -26,7 +26,7 @@ class DropTableSuite extends v1.DropTableSuiteBase with CommandSuiteBase {
test("hive client calls") {
withNamespaceAndTable("ns", "tbl") { t =>
sql(s"CREATE TABLE $t (id int) $defaultUsing")
- checkHiveClientCalls(expected = 11) {
+ checkHiveClientCalls(expected = 10) {
Review Comment:
Why this is changed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1221129625
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:
##########
@@ -849,6 +849,7 @@ class SessionCatalog(
tempViews.remove(table)
}
}
+ invalidateCachedTable(name)
Review Comment:
This is a special logic only for `SesssionCatalog`, should I add special case for it in `DropTableExec`? I think this is a bad start and breaks the generality of V2 command.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1221254744
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:
##########
@@ -849,6 +849,7 @@ class SessionCatalog(
tempViews.remove(table)
}
}
+ invalidateCachedTable(name)
Review Comment:
oh I see, shall we move it to `V2SessionCatalog` then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1222589939
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/connector/IdentifierImpl.scala:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.internal.connector
+
+import java.util.{Objects, StringJoiner}
+
+import org.apache.spark.annotation.Evolving
+import org.apache.spark.sql.catalyst.util.quoteIfNeeded
+import org.apache.spark.sql.connector.catalog.Identifier
+
+/**
+ * An {@link Identifier} implementation.
+ */
+@Evolving
+class IdentifierImpl(namespace: Array[String], name: String)
Review Comment:
oh, I think it's unnecessary now, as the test uses `Identifier.of` and doesn't need to access `IdentifierImpl` anymore.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1212863060
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala:
##########
@@ -71,7 +71,12 @@ class V2SessionCatalog(catalog: SessionCatalog)
}
override def loadTable(ident: Identifier): Table = {
- V1Table(catalog.getTableMetadata(ident.asTableIdentifier))
+ try {
+ V1Table(catalog.getTableMetadata(ident.asTableIdentifier))
+ } catch {
+ case _: NoSuchDatabaseException =>
Review Comment:
does it cause test failures?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1208726693
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/IdentifierImpl.java:
##########
@@ -30,12 +30,12 @@
* An {@link Identifier} implementation.
*/
@Evolving
-class IdentifierImpl implements Identifier {
+public class IdentifierImpl implements Identifier {
Review Comment:
change scope to public, so can create it by test in https://github.com/apache/spark/pull/41348/files#diff-7ce7e7e03723d865798a6dcb6efa81aea25e925397e4c9288bbfd3317c8a515bR694-R698
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:
##########
@@ -849,6 +849,7 @@ class SessionCatalog(
tempViews.remove(table)
}
}
+ invalidateCachedTable(name)
Review Comment:
add `invalidateCachedTable`, it's logic which `DropTableCommand` will do in v1.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala:
##########
@@ -71,7 +71,12 @@ class V2SessionCatalog(catalog: SessionCatalog)
}
override def loadTable(ident: Identifier): Table = {
- V1Table(catalog.getTableMetadata(ident.asTableIdentifier))
+ try {
+ V1Table(catalog.getTableMetadata(ident.asTableIdentifier))
+ } catch {
+ case _: NoSuchDatabaseException =>
Review Comment:
loadTable will return `NoSuchDatabaseException`, not same as v1 behavior.
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/CacheManager.scala:
##########
@@ -190,6 +191,11 @@ class CacheManager extends Logging with AdaptiveSparkPlanHelper {
isSameName(ident.qualifier :+ ident.name) &&
isSameName(v1Ident.catalog.toSeq ++ v1Ident.database :+ v1Ident.table)
+ case SubqueryAlias(ident, HiveTableRelation(catalogTable, _, _, _, _)) =>
Review Comment:
Add support for `HiveTableRelation` in `isMatchedTableOrView`, so that can remove Cache normally when use hive catalog.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1220983601
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:
##########
@@ -849,6 +849,7 @@ class SessionCatalog(
tempViews.remove(table)
}
}
+ invalidateCachedTable(name)
Review Comment:
Since it was done in the command before, shall we also do it in the v2 command? others may rely on the APIs in the SessionCatalog so we'd better not change it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1221302284
##########
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/V2SessionCatalog.scala:
##########
@@ -194,12 +203,28 @@ class V2SessionCatalog(catalog: SessionCatalog)
}
override def dropTable(ident: Identifier): Boolean = {
+ dropTableInternal(ident)
+ }
+
+ private def dropTableInternal(ident: Identifier, purge: Boolean = false): Boolean = {
try {
- if (loadTable(ident) != null) {
+ val table = loadTable(ident)
+ if (table != null) {
+ val v1Table = table.asInstanceOf[V1Table].v1Table
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on PR #41348:
URL: https://github.com/apache/spark/pull/41348#issuecomment-1586002455
> Could you re-trigger CI?
Done, please wait.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #41348:
URL: https://github.com/apache/spark/pull/41348#issuecomment-1586000745
Could you re-trigger CI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
URL: https://github.com/apache/spark/pull/41348
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #41348:
URL: https://github.com/apache/spark/pull/41348#issuecomment-1610339428
I'm okay with changing it to bug and backport to 3.4.2. cc @cloud-fan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1221256203
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:
##########
@@ -849,6 +849,7 @@ class SessionCatalog(
tempViews.remove(table)
}
}
+ invalidateCachedTable(name)
Review Comment:
An obvious flaw now is if people fallback to v1 command, we invalidate the cache twice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1222860848
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/connector/IdentifierImpl.scala:
##########
@@ -0,0 +1,63 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.internal.connector
+
+import java.util.{Objects, StringJoiner}
+
+import org.apache.spark.annotation.Evolving
+import org.apache.spark.sql.catalyst.util.quoteIfNeeded
+import org.apache.spark.sql.connector.catalog.Identifier
+
+/**
+ * An {@link Identifier} implementation.
+ */
+@Evolving
+class IdentifierImpl(namespace: Array[String], name: String)
Review Comment:
Reverted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1221277562
##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala:
##########
@@ -849,6 +849,7 @@ class SessionCatalog(
tempViews.remove(table)
}
}
+ invalidateCachedTable(name)
Review Comment:
> shall we move it to V2SessionCatalog then?
good idea, done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1223519017
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/IdentifierImpl.java:
##########
@@ -30,12 +30,12 @@
* An {@link Identifier} implementation.
*/
@Evolving
-class IdentifierImpl implements Identifier {
+public class IdentifierImpl implements Identifier {
Review Comment:
Does this need to be public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] Hisoka-X commented on a diff in pull request #41348: [SPARK-43203][SQL] Move all Drop Table case to DataSource V2
Posted by "Hisoka-X (via GitHub)" <gi...@apache.org>.
Hisoka-X commented on code in PR #41348:
URL: https://github.com/apache/spark/pull/41348#discussion_r1223661427
##########
sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/IdentifierImpl.java:
##########
@@ -30,12 +30,12 @@
* An {@link Identifier} implementation.
*/
@Evolving
-class IdentifierImpl implements Identifier {
+public class IdentifierImpl implements Identifier {
Review Comment:
Oops, thanks for remind, the revert commit bring expired code. Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org