You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/05/20 05:31:03 UTC

[GitHub] [apisix] soulbird commented on a diff in pull request #7085: test: reduce CI failure caused by flaky tests

soulbird commented on code in PR #7085:
URL: https://github.com/apache/apisix/pull/7085#discussion_r877747039


##########
t/plugin/file-logger-reopen.t:
##########
@@ -135,6 +136,7 @@ file.log: No such file or directory
             end
 
             local code = t("/hello", ngx.HTTP_GET)
+            assert(code == 200)

Review Comment:
   why this assertion is needed？



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org