You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by zjffdu <gi...@git.apache.org> on 2018/03/07 03:57:34 UTC

[GitHub] zeppelin pull request #2845: ZEPPELIN-3304. Move sap module before zeppelin-...

GitHub user zjffdu opened a pull request:

    https://github.com/apache/zeppelin/pull/2845

    ZEPPELIN-3304. Move sap module before zeppelin-distribution

    ### What is this PR for?
    1. Move sap module before zeppelin-distribution, otherwise sap module will be built after zeppelin-distribution
    2. Fix code style issue of sap module
    3. Update travis to include sap module
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3304
    
    ### How should this be tested?
    * CI pass
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zjffdu/zeppelin ZEPPELIN-3304

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2845.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2845
    
----
commit 533a1b035f11466969b8f7f463c653e9a6d050f2
Author: Jeff Zhang <zj...@...>
Date:   2018-03-07T03:54:51Z

    ZEPPELIN-3304. Move sap module before zeppelin-distribution

----


---

[GitHub] zeppelin pull request #2845: ZEPPELIN-3304. Move sap module before zeppelin-...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2845


---

[GitHub] zeppelin issue #2845: ZEPPELIN-3304. Move sap module before zeppelin-distrib...

Posted by masyan <gi...@git.apache.org>.
Github user masyan commented on the issue:

    https://github.com/apache/zeppelin/pull/2845
  
    thx.  LGTM


---