You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "Abacn (via GitHub)" <gi...@apache.org> on 2024/04/27 00:54:14 UTC
[PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Abacn opened a new pull request, #31125:
URL: https://github.com/apache/beam/pull/31125
Resolve https://github.com/apache/beam/issues/30646#issuecomment-2080102737
* Reject split attempt early when there is an ongoing hasNext call in work item thread
* TImeout hasNext call in splitAtFraction in alignment with client splitReadStreamSettings
The issue exist on both released Beam and after #30646
Tested on read stream API v1 (default) and Dataflow legacy runner in a quota restricted project:
<img width="987" alt="image" src="https://github.com/apache/beam/assets/8010435/156dc67a-468a-4016-8f09-d32eed5652ad">
Without the change, the pipeline appears to stuck indefinitely. the [onRetryAttempt](https://github.com/apache/beam/blob/673da546c1465c931fdbbc5769e7d566ff55b4d8/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java#L1683) callback get called periodically.
**Please** add a meaningful description for your change here
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31125:
URL: https://github.com/apache/beam/pull/31125#issuecomment-2083346916
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @damondouglas for label java.
R: @chamikaramj for label io.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #31125:
URL: https://github.com/apache/beam/pull/31125#discussion_r1591253151
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java:
##########
@@ -238,9 +245,12 @@ public synchronized boolean advance() throws IOException {
private synchronized boolean readNextRecord() throws IOException {
Iterator<ReadRowsResponse> responseIterator = this.responseIterator;
while (reader.readyForNextReadResponse()) {
+ boolean previous = splitAllowed;
+ splitAllowed = false;
// hasNext call has internal retry. Record throttling metrics after called
boolean hasNext = responseIterator.hasNext();
storageClient.reportPendingMetrics();
+ splitAllowed = previous;
Review Comment:
Yeah, it is fine to move around these two lines, as long as splitAllowed is temporarily disabled during hasNext call. Will fix to make it clear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #31125:
URL: https://github.com/apache/beam/pull/31125#discussion_r1581722468
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java:
##########
@@ -388,8 +398,22 @@ public synchronized BigQueryStorageStreamSource<T> getCurrentSource() {
// The following line is required to trigger the `FailedPreconditionException` on which
// the SplitReadStream validation logic depends. Removing it will cause incorrect
// split operations to succeed.
- newResponseIterator.hasNext();
- storageClient.reportPendingMetrics();
Review Comment:
removed reportPendingMetrics call here otherwise same warning as #31096 seen, because splitAtFraction call thread isn't a work item thread
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #31125:
URL: https://github.com/apache/beam/pull/31125#issuecomment-2096752041
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/31125?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `53.84615%` with `6 lines` in your changes are missing coverage. Please review.
> Project coverage is 60.41%. Comparing base [(`b34cf54`)](https://app.codecov.io/gh/apache/beam/commit/b34cf54b0a1511e88f76836d040c4ee67e420a71?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`4b3dd6a`)](https://app.codecov.io/gh/apache/beam/pull/31125?dropdown=coverage&src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 122 commits behind head on master.
| [Files](https://app.codecov.io/gh/apache/beam/pull/31125?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...k/io/gcp/bigquery/BigQueryStorageStreamSource.java](https://app.codecov.io/gh/apache/beam/pull/31125?src=pr&el=tree&filepath=sdks%2Fjava%2Fio%2Fgoogle-cloud-platform%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fbeam%2Fsdk%2Fio%2Fgcp%2Fbigquery%2FBigQueryStorageStreamSource.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9qYXZhL2lvL2dvb2dsZS1jbG91ZC1wbGF0Zm9ybS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvYmVhbS9zZGsvaW8vZ2NwL2JpZ3F1ZXJ5L0JpZ1F1ZXJ5U3RvcmFnZVN0cmVhbVNvdXJjZS5qYXZh) | 53.84% | [6 Missing :warning: ](https://app.codecov.io/gh/apache/beam/pull/31125?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #31125 +/- ##
=============================================
- Coverage 71.44% 60.41% -11.04%
- Complexity 1474 2981 +1507
=============================================
Files 906 659 -247
Lines 113271 66095 -47176
Branches 1076 3233 +2157
=============================================
- Hits 80931 39930 -41001
+ Misses 30327 23066 -7261
- Partials 2013 3099 +1086
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/31125/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [java](https://app.codecov.io/gh/apache/beam/pull/31125/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `68.62% <53.84%> (+0.04%)` | :arrow_up: |
| [python](https://app.codecov.io/gh/apache/beam/pull/31125/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/beam/pull/31125?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #31125:
URL: https://github.com/apache/beam/pull/31125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on code in PR #31125:
URL: https://github.com/apache/beam/pull/31125#discussion_r1591097140
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageReadTest.java:
##########
@@ -1384,6 +1386,87 @@ public KV<String, Long> apply(SchemaAndRecord input) {
}
}
+ static class StuckResponse extends ArrayList<ReadRowsResponse> {
+
+ private CountDownLatch latch;
+
+ public StuckResponse(CountDownLatch latch) {
+ this.latch = latch;
+ }
+
+ @Override
+ public Iterator<ReadRowsResponse> iterator() {
+ return new StuckIterator();
+ }
+
+ private class StuckIterator implements Iterator<ReadRowsResponse> {
+
+ @Override
+ public boolean hasNext() {
+ latch.countDown();
+ try {
+ Thread.sleep(Long.MAX_VALUE);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ }
+ return false;
+ }
+
+ @Override
+ public ReadRowsResponse next() {
+ return null;
+ }
+ }
+ }
+
+ @Test
+ public void testStreamSourceSplitAtFractionFailsWhenReaderRunning() throws Exception {
+ ReadSession readSession =
+ ReadSession.newBuilder()
+ .setName("readSession")
+ .setAvroSchema(AvroSchema.newBuilder().setSchema(AVRO_SCHEMA_STRING))
+ .build();
+
+ ReadRowsRequest expectedRequest =
+ ReadRowsRequest.newBuilder().setReadStream("readStream").build();
+
+ CountDownLatch latch = new CountDownLatch(1);
+ StorageClient fakeStorageClient = mock(StorageClient.class);
+ when(fakeStorageClient.readRows(expectedRequest, ""))
+ .thenReturn(new FakeBigQueryServerStream<>(new StuckResponse(latch)));
+
+ // new StuckIteratorList<Void>()
Review Comment:
cleanup
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java:
##########
@@ -238,9 +245,12 @@ public synchronized boolean advance() throws IOException {
private synchronized boolean readNextRecord() throws IOException {
Iterator<ReadRowsResponse> responseIterator = this.responseIterator;
while (reader.readyForNextReadResponse()) {
+ boolean previous = splitAllowed;
+ splitAllowed = false;
// hasNext call has internal retry. Record throttling metrics after called
boolean hasNext = responseIterator.hasNext();
storageClient.reportPendingMetrics();
+ splitAllowed = previous;
Review Comment:
Why the need to set `splitAllowed` to false while reporting metrics?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #31125:
URL: https://github.com/apache/beam/pull/31125#discussion_r1581648996
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java:
##########
@@ -388,8 +398,22 @@ public synchronized BigQueryStorageStreamSource<T> getCurrentSource() {
// The following line is required to trigger the `FailedPreconditionException` on which
// the SplitReadStream validation logic depends. Removing it will cause incorrect
// split operations to succeed.
- newResponseIterator.hasNext();
- storageClient.reportPendingMetrics();
+ Future<Boolean> future = executor.submit(newResponseIterator::hasNext);
+ try {
+ // The intended wait time is in sync with splitReadStreamSettings.setRetrySettings in
+ // StorageClientImpl.
+ future.get(30, TimeUnit.SECONDS);
Review Comment:
This is correspond to the config here
https://github.com/apache/beam/blob/673da546c1465c931fdbbc5769e7d566ff55b4d8/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java#L1735-L1742
It intended to set the API call timeout during split request to 30s (and otherwise reject split). However, a bug fix #21739 added this call here, which has internal retry logic, but it is not covered the split-stream-retry config. When there is quota issue, this is causing pipeline stuck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #31125:
URL: https://github.com/apache/beam/pull/31125#discussion_r1581648996
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java:
##########
@@ -388,8 +398,22 @@ public synchronized BigQueryStorageStreamSource<T> getCurrentSource() {
// The following line is required to trigger the `FailedPreconditionException` on which
// the SplitReadStream validation logic depends. Removing it will cause incorrect
// split operations to succeed.
- newResponseIterator.hasNext();
- storageClient.reportPendingMetrics();
+ Future<Boolean> future = executor.submit(newResponseIterator::hasNext);
+ try {
+ // The intended wait time is in sync with splitReadStreamSettings.setRetrySettings in
+ // StorageClientImpl.
+ future.get(30, TimeUnit.SECONDS);
Review Comment:
This is correspond to the config here
https://github.com/apache/beam/blob/673da546c1465c931fdbbc5769e7d566ff55b4d8/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java#L1735-L1742
It intended to set the API call timeout during split request to 30s (and otherwise reject split). However, a bug fix #21739 added this call here, which has internal retry logic, but this added call is not covered by the split-stream-retry config above. When there is quota issue, this is causing pipeline stuck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #31125:
URL: https://github.com/apache/beam/pull/31125#discussion_r1581651936
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageReadTest.java:
##########
@@ -1384,6 +1386,91 @@ public KV<String, Long> apply(SchemaAndRecord input) {
}
}
+ static class StuckResponse extends ArrayList<ReadRowsResponse> {
+
+ private CountDownLatch latch;
+
+ public StuckResponse(CountDownLatch latch) {
+ this.latch = latch;
+ }
+
+ static final Object lock = new Object();
+
+ static boolean hasNextCalled = false;
+
+ @Override
+ public Iterator<ReadRowsResponse> iterator() {
+ return new StuckIterator();
+ }
+
+ private class StuckIterator implements Iterator<ReadRowsResponse> {
+
+ @Override
+ public boolean hasNext() {
+ latch.countDown();
+ try {
+ Thread.sleep(Long.MAX_VALUE);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ }
+ return false;
+ }
+
+ @Override
+ public ReadRowsResponse next() {
+ return null;
+ }
+ }
+ }
+
+ @Test
+ public void testStreamSourceSplitAtFractionFailsWhenReaderRunning() throws Exception {
+ ReadSession readSession =
+ ReadSession.newBuilder()
+ .setName("readSession")
+ .setAvroSchema(AvroSchema.newBuilder().setSchema(AVRO_SCHEMA_STRING))
+ .build();
+
+ ReadRowsRequest expectedRequest =
+ ReadRowsRequest.newBuilder().setReadStream("readStream").build();
+
+ CountDownLatch latch = new CountDownLatch(1);
+ StorageClient fakeStorageClient = mock(StorageClient.class);
+ when(fakeStorageClient.readRows(expectedRequest, ""))
+ .thenReturn(new FakeBigQueryServerStream<>(new StuckResponse(latch)));
+
+ // new StuckIteratorList<Void>()
+
+ BigQueryStorageStreamSource<TableRow> streamSource =
+ BigQueryStorageStreamSource.create(
+ readSession,
+ ReadStream.newBuilder().setName("readStream").build(),
+ TABLE_SCHEMA,
+ new TableRowParser(),
+ TableRowJsonCoder.of(),
+ new FakeBigQueryServices().withStorageClient(fakeStorageClient));
+
+ BigQueryStorageStreamReader<TableRow> reader = streamSource.createReader(options);
+
+ Thread t =
+ new Thread(
+ () -> {
+ try {
+ reader.start();
+ } catch (IOException e) {
+ throw new RuntimeException(e);
+ }
+ });
+ t.start();
+
+ // wait until thread proceed
+ latch.await();
+
+ // Beam does not split storage read api v2 stream
+ assertNull(reader.splitAtFraction(0.5));
Review Comment:
without the changes in main scope code, the test fails with
```
java.lang.NullPointerException
at org.apache.beam.sdk.io.gcp.bigquery.BigQueryStorageStreamSource$BigQueryStorageStreamReader.splitAtFraction(BigQueryStorageStreamSource.java:372)
```
because it passed "splitAllowed" check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #31125:
URL: https://github.com/apache/beam/pull/31125#discussion_r1591247878
##########
sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryIOStorageReadTest.java:
##########
@@ -1384,6 +1386,87 @@ public KV<String, Long> apply(SchemaAndRecord input) {
}
}
+ static class StuckResponse extends ArrayList<ReadRowsResponse> {
+
+ private CountDownLatch latch;
+
+ public StuckResponse(CountDownLatch latch) {
+ this.latch = latch;
+ }
+
+ @Override
+ public Iterator<ReadRowsResponse> iterator() {
+ return new StuckIterator();
+ }
+
+ private class StuckIterator implements Iterator<ReadRowsResponse> {
+
+ @Override
+ public boolean hasNext() {
+ latch.countDown();
+ try {
+ Thread.sleep(Long.MAX_VALUE);
+ } catch (InterruptedException e) {
+ Thread.currentThread().interrupt();
+ }
+ return false;
+ }
+
+ @Override
+ public ReadRowsResponse next() {
+ return null;
+ }
+ }
+ }
+
+ @Test
+ public void testStreamSourceSplitAtFractionFailsWhenReaderRunning() throws Exception {
+ ReadSession readSession =
+ ReadSession.newBuilder()
+ .setName("readSession")
+ .setAvroSchema(AvroSchema.newBuilder().setSchema(AVRO_SCHEMA_STRING))
+ .build();
+
+ ReadRowsRequest expectedRequest =
+ ReadRowsRequest.newBuilder().setReadStream("readStream").build();
+
+ CountDownLatch latch = new CountDownLatch(1);
+ StorageClient fakeStorageClient = mock(StorageClient.class);
+ when(fakeStorageClient.readRows(expectedRequest, ""))
+ .thenReturn(new FakeBigQueryServerStream<>(new StuckResponse(latch)));
+
+ // new StuckIteratorList<Void>()
Review Comment:
thanks, good catch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Posted by "ahmedabu98 (via GitHub)" <gi...@apache.org>.
ahmedabu98 commented on code in PR #31125:
URL: https://github.com/apache/beam/pull/31125#discussion_r1591283630
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java:
##########
@@ -238,9 +245,12 @@ public synchronized boolean advance() throws IOException {
private synchronized boolean readNextRecord() throws IOException {
Iterator<ReadRowsResponse> responseIterator = this.responseIterator;
while (reader.readyForNextReadResponse()) {
+ boolean previous = splitAllowed;
+ splitAllowed = false;
// hasNext call has internal retry. Record throttling metrics after called
boolean hasNext = responseIterator.hasNext();
storageClient.reportPendingMetrics();
+ splitAllowed = previous;
Review Comment:
thanks, might be good to add a small comment that we shouldn't split while waiting for this API call
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31125:
URL: https://github.com/apache/beam/pull/31125#issuecomment-2080313427
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment `assign set of reviewers`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #31125:
URL: https://github.com/apache/beam/pull/31125#discussion_r1581648996
##########
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryStorageStreamSource.java:
##########
@@ -388,8 +398,22 @@ public synchronized BigQueryStorageStreamSource<T> getCurrentSource() {
// The following line is required to trigger the `FailedPreconditionException` on which
// the SplitReadStream validation logic depends. Removing it will cause incorrect
// split operations to succeed.
- newResponseIterator.hasNext();
- storageClient.reportPendingMetrics();
+ Future<Boolean> future = executor.submit(newResponseIterator::hasNext);
+ try {
+ // The intended wait time is in sync with splitReadStreamSettings.setRetrySettings in
+ // StorageClientImpl.
+ future.get(30, TimeUnit.SECONDS);
Review Comment:
This is correspond to the config here
https://github.com/apache/beam/blob/673da546c1465c931fdbbc5769e7d566ff55b4d8/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java#L1735-L1742
It intended to set the API call timeout during split request to 30s (and otherwise reject split). However, a bug fix #21739 added this call here, which has internal retry logic, but this added call is not covered the split-stream-retry config. When there is quota issue, this is causing pipeline stuck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #31125:
URL: https://github.com/apache/beam/pull/31125#issuecomment-2086989569
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Suppress BigQuery read stream splitAtFraction when API busy call or timeout [beam]
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on PR #31125:
URL: https://github.com/apache/beam/pull/31125#issuecomment-2086981568
R: @ahmedabu98 (since you reviewed #31096)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org