You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Aurelien DE FANTI <a_...@yahoo.fr> on 2012/11/19 23:19:55 UTC
Review Request: adding mysql-connector-java dependency into
dependencyManagement and using 5.1.21 version only
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8129/
-----------------------------------------------------------
Review request for cloudstack.
Description
-------
Maven :
dependencyManagement section is created in cloudstack pom.
mysql-connector-java dependency is added in this section.
cs.mysql.version is updated from 5.1.12 to 5.1.21 (this second version was used in cloud-client-ui, cloud-awsapi and cloud-utils modules)
Diffs
-----
awsapi/pom.xml bc62bd6
client/pom.xml 056e560
pom.xml 08f61f5
server/pom.xml cd4fbbe
utils/pom.xml 2e4e74f
Diff: https://reviews.apache.org/r/8129/diff/
Testing
-------
mvn clean install
Thanks,
Aurelien DE FANTI
Re: Review Request: maven : adding mysql-connector-java dependency into
dependencyManagement and using 5.1.21 version only
Posted by Aurelien DE FANTI <a_...@yahoo.fr>.
> On Nov. 20, 2012, 2:16 a.m., Satoshi Kobayashi wrote:
> > An intention of the patch is refactoring?
> > This looks good for me.
Yes, it's a little maven refactoring (it's only the second time I post a review) and using dependencyManagement simplifies others maven poms.
- Aurelien
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8129/#review13613
-----------------------------------------------------------
On Nov. 19, 2012, 10:28 p.m., Aurelien DE FANTI wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8129/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 10:28 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Maven :
> dependencyManagement section is created in cloudstack pom.
> mysql-connector-java dependency is added in this section.
> cs.mysql.version is updated from 5.1.12 to 5.1.21 (this second version was used in cloud-client-ui, cloud-awsapi and cloud-utils modules)
>
>
> Diffs
> -----
>
> awsapi/pom.xml bc62bd6
> client/pom.xml 056e560
> pom.xml 08f61f5
> server/pom.xml cd4fbbe
> utils/pom.xml 2e4e74f
>
> Diff: https://reviews.apache.org/r/8129/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
>
> Thanks,
>
> Aurelien DE FANTI
>
>
Re: Review Request: maven : adding mysql-connector-java dependency into
dependencyManagement and using 5.1.21 version only
Posted by Satoshi Kobayashi <sa...@stratosphere.co.jp>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8129/#review13613
-----------------------------------------------------------
An intention of the patch is refactoring?
This looks good for me.
- Satoshi Kobayashi
On Nov. 19, 2012, 10:28 p.m., Aurelien DE FANTI wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8129/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 10:28 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Maven :
> dependencyManagement section is created in cloudstack pom.
> mysql-connector-java dependency is added in this section.
> cs.mysql.version is updated from 5.1.12 to 5.1.21 (this second version was used in cloud-client-ui, cloud-awsapi and cloud-utils modules)
>
>
> Diffs
> -----
>
> awsapi/pom.xml bc62bd6
> client/pom.xml 056e560
> pom.xml 08f61f5
> server/pom.xml cd4fbbe
> utils/pom.xml 2e4e74f
>
> Diff: https://reviews.apache.org/r/8129/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
>
> Thanks,
>
> Aurelien DE FANTI
>
>
Re: Review Request: maven : adding mysql-connector-java dependency into
dependencyManagement and using 5.1.21 version only
Posted by Hugo Trippaers <ht...@schubergphilis.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8129/#review13620
-----------------------------------------------------------
Ship it!
Ship It!
- Hugo Trippaers
On Nov. 19, 2012, 10:28 p.m., Aurelien DE FANTI wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8129/
> -----------------------------------------------------------
>
> (Updated Nov. 19, 2012, 10:28 p.m.)
>
>
> Review request for cloudstack.
>
>
> Description
> -------
>
> Maven :
> dependencyManagement section is created in cloudstack pom.
> mysql-connector-java dependency is added in this section.
> cs.mysql.version is updated from 5.1.12 to 5.1.21 (this second version was used in cloud-client-ui, cloud-awsapi and cloud-utils modules)
>
>
> Diffs
> -----
>
> awsapi/pom.xml bc62bd6
> client/pom.xml 056e560
> pom.xml 08f61f5
> server/pom.xml cd4fbbe
> utils/pom.xml 2e4e74f
>
> Diff: https://reviews.apache.org/r/8129/diff/
>
>
> Testing
> -------
>
> mvn clean install
>
>
> Thanks,
>
> Aurelien DE FANTI
>
>
Re: Review Request: maven : adding mysql-connector-java dependency into
dependencyManagement and using 5.1.21 version only
Posted by Aurelien DE FANTI <a_...@yahoo.fr>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8129/
-----------------------------------------------------------
(Updated Nov. 19, 2012, 10:28 p.m.)
Review request for cloudstack.
Summary (updated)
-----------------
maven : adding mysql-connector-java dependency into dependencyManagement and using 5.1.21 version only
Description
-------
Maven :
dependencyManagement section is created in cloudstack pom.
mysql-connector-java dependency is added in this section.
cs.mysql.version is updated from 5.1.12 to 5.1.21 (this second version was used in cloud-client-ui, cloud-awsapi and cloud-utils modules)
Diffs
-----
awsapi/pom.xml bc62bd6
client/pom.xml 056e560
pom.xml 08f61f5
server/pom.xml cd4fbbe
utils/pom.xml 2e4e74f
Diff: https://reviews.apache.org/r/8129/diff/
Testing
-------
mvn clean install
Thanks,
Aurelien DE FANTI